Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,17 @@ This repository aims to follow [semantic versioning](https://semver.org).

The Bazel community maintains this repository. Neither Google nor the Bazel team provides support for the code. However, this repository is part of the test suite used to vet new Bazel releases. See [How to contribute](CONTRIBUTING.md) page for information on our development workflow.

## Design

* Supported OSes - as per our supported platform policy, we strive for support on all of the platforms that we have CI for. Some platforms do not have the same backwards compatibility guarantees, but we hope the community can step in where needed to make the support more robust.
* `requirements.txt` is how users have been defining dependencies for a long time. We support this to support legacy usecases or package managers that we don't support directly. Any additional information that we need will be retrieved from the SimpleAPI during the `bzlmod` extension evaluation phase. Then it will be written to the `MODULE.bazel.lock` file for future reuse. We have plans to support `uv.lock` file directly. `uv` is recommended for generating a fully locked `requirements.txt` file and we do provide a rule for it.
Comment thread
rickeylev marked this conversation as resolved.
Outdated
* The `py_binary`, `py_test` rules should scale to large monorepos and we work hard to minimize the work done during analysis and build phase. What is more, the space requirements for should be minimal, so we strive to use symlinks rather than extracting wheels at build time. This means that for different configurations of the same build, we are not extracting the wheel multiple times thus scaling better over the time. From `2.0` onwards we are creating a virtual env for each target by creating an actual minimal virtual environment using symlinks. We plan on creating the traditional `site-packages` layout in the future by default.
* Support for standards - we strive to first implement any standards needed within `rules_python` and this has resulted in a few PEPs supported within pure starlark - PEP440, PEP509.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These lines exceed the 100-character limit. Additionally, line 26 contains grammatical errors ('space requirements for should be' and 'over the time'), and line 27 likely refers to PEP 508 (Dependency specification) rather than PEP 509 (Dictionary versioning).

References
  1. Max line length: 100. (link)


Common misconceptions:
* `rules_python` has to keep backwards compatibility with `google3`. Whilst this might have been true in the past, `rules_python` is an open source project and any compatibility needs should come from the community - we have no requirement to keep this compatibility and are allowed to make our decisions. However, we do want to keep backwards compatibility as long as possible to not upset users with never ending migrations.
* `rules_python` is not caching pip downloads. With 2.0, we use Bazel's downloader by default and rely on bazel to provide the repository caching mechanisms. This means that for simpler setups this should result in transparent and scalable caching with the most recent bazel versions unless there are issues in the bazel itself.
Comment thread
rickeylev marked this conversation as resolved.
Outdated

## Documentation

For detailed documentation, see <https://rules-python.readthedocs.io>
Expand Down
Loading