Skip to content

fix(pypi): harden the WORKSPACE python detection in pip_repository #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aignas merged 5 commits into from
Apr 29, 2026
+8 −5
Merged

fix(pypi): harden the WORKSPACE python detection in pip_repository #3744

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
14e96bd
fix(pypi): harden the WORKSPACE python detection in pip_repository
aignas Apr 27, 2026
a65b5c0
improve
aignas Apr 27, 2026
c0d20c4
fixup evaluate_markers signature in WORKSPACE
aignas Apr 27, 2026
00b68a7
Revert "fixup evaluate_markers signature in WORKSPACE"
aignas Apr 27, 2026
b691797
use pypi_repo_utils
aignas Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions python/private/pypi/pip_repository.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,10 @@ def _pip_repository_impl(rctx):
python_interpreter = rctx.attr.python_interpreter,
python_interpreter_target = rctx.attr.python_interpreter_target,
)
result = rctx.execute([python_interpreter, "--version"])
if result.stdout:
python_version = result.stdout.strip().split(" ")[-1]
else:
fail("Could not determine Python version")
result = rctx.execute([python_interpreter, "-S", "-c", "import sys; print(sys.version.split()[0])"])
Comment thread
aignas marked this conversation as resolved.
Outdated
if result.return_code != 0 or not result.stdout.strip():
fail("Could not determine Python version for interpreter %s: %s" % (python_interpreter, result.stderr or result.stdout))
python_version = result.stdout.strip().splitlines()[-1]
platforms = [
"linux_aarch64",
"linux_arm",
Expand Down