Skip to content

fix(system_python): Remove printing of not always present attribute #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aignas merged 5 commits into from
May 20, 2026
+4 −2
Merged

fix(system_python): Remove printing of not always present attribute #3781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6176f76
fix(system_python): Remove printing of not always present attribute
limdor May 16, 2026
af645a1
Merge branch 'main' into fix_rules_python
aignas May 20, 2026
38eb57b
fix: revert the removal and use getattr
aignas May 20, 2026
3706397
Apply suggestion from @aignas
aignas May 20, 2026
f8f555f
Merge branch 'main' into fix_rules_python
aignas May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ END_UNRELEASED_TEMPLATE
* (pypi) Fix `importlib.metadata.files` by ensuring `RECORD` is included in
installed wheel targets, except when built from sdist
([#3024](https://github.com/bazel-contrib/rules_python/issues/3024)).
* (system_python) Fix AttributeError exception on Debian 10 Buster
Comment thread
aignas marked this conversation as resolved.
python installations which may not set `sys._base_executable`
([#3774](https://github.com/bazel-contrib/rules_python/issues/3774)).
* (windows) Fix `py_test`/`py_binary` failure when the target name contains
path separators; the bootstrap stub is now declared as a sibling of the
`.exe` launcher
Expand All @@ -92,7 +95,6 @@ END_UNRELEASED_TEMPLATE
towards the underlying `*.update` target.
([#3787](https://github.com/bazel-contrib/rules_python/pull/3787))


{#v0-0-0-added}
### Added
* (toolchain) Added {obj}`python.override.toolchain_target_settings` to allow
Expand Down
2 changes: 1 addition & 1 deletion python/private/python_bootstrap_template.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ def main():
print_verbose("VENV_REL_SITE_PACKAGES:", VENV_REL_SITE_PACKAGES)
print_verbose("WORKSPACE_NAME:", WORKSPACE_NAME )
print_verbose("bootstrap sys.executable:", sys.executable)
print_verbose("bootstrap sys._base_executable:", sys._base_executable)
Copy link
Copy Markdown
Collaborator

@aignas aignas May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preferably it would be better to not remove but to use getattr for this.

Suggested change
print_verbose("bootstrap sys._base_executable:", sys._base_executable)
print_verbose("bootstrap sys._base_executable:", getattr(sys, "_base_executable", "unknown"))

print_verbose("bootstrap sys._base_executable:", getattr(sys, "_base_executable", "unknown"))
print_verbose("bootstrap sys.version:", sys.version)

args = sys.argv[1:]
Expand Down