Skip to content

fix(pip_compile): Forward target compatibility to *.update #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aignas merged 2 commits into from
May 20, 2026
+4 −0
Merged

fix(pip_compile): Forward target compatibility to *.update #3787

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95fcfbb
pip_compile: Forward target compatibility to *.update
castler May 18, 2026
bb55b05
Apply suggestion from @aignas
aignas May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ END_UNRELEASED_TEMPLATE
path separators; the bootstrap stub is now declared as a sibling of the
`.exe` launcher
([#3789](https://github.com/bazel-contrib/rules_python/issues/3789)).
* Fix the forwarding of `target_compatible_with` from `compile_pip_requirements`
towards the underlying `*.update` target
Comment thread
aignas marked this conversation as resolved.
Outdated


{#v0-0-0-added}
Expand Down
1 change: 1 addition & 0 deletions python/private/pypi/pip_compile.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ def pip_compile(
name = name + ".update",
env = env,
python_version = kwargs.get("python_version", None),
target_compatible_with = kwargs.get("target_compatible_with", []),
Comment thread
aignas marked this conversation as resolved.
**attrs
)

Expand Down