fix: avoid ln race condition in bootstrap script#3797
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic toolchain registration by parsing python-build-standalone manifests, adding support for downloading and parsing SHA256SUMS files to dynamically register Python versions. It also updates the bootstrap template to handle symlink creation more robustly during startup. The review feedback highlights critical issues, including a Starlark runtime crash due to the unsupported rpartition method, a fragile platform matching strategy that fails with microarchitecture suffixes, potential startup failures from stale or broken symlinks in the bootstrap script, and a recommendation to strip leading asterisks from filenames in manifest files for increased robustness.
|
Argh, somehow it picked the wrong base commit or something. I gotta go futz with this... |
rickeylev
force-pushed
the
fix-ln-race-condition-20260527
branch
from
0e4830a to
af48d0c
Compare
Avoid startup failures when multiple processes attempt to create the same symlinks simultaneously. Ensure symlinks are created and ignore errors if they already exist, which can happen in a race condition during startup.
rickeylev
force-pushed
the
fix-ln-race-condition-20260527
branch
from
af48d0c to
63757d6
Compare
|
Alright, fixed the commits. Ready for review |
2 participants
Avoid startup failures when multiple processes attempt to create the same symlinks simultaneously.
Ensure symlinks are created and ignore errors if they already exist, which can happen in a race condition during startup.