chore: use direct @dev_pip targets instead of requirement()#3798
Merged
rickeylev merged 1 commit intoMay 27, 2026
Merged
Conversation
Use @dev_pip//<pkg> format instead of the requirement() macro. This aligns with modern bzlmod patterns and simplifies the BUILD file.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates docs/BUILD.bazel by removing the requirement macro load from @dev_pip//:requirements.bzl and refactoring the dependencies of sphinx_build_binary to use direct labels (e.g., @dev_pip//myst_parser) instead of the macro. The dependencies have also been sorted alphabetically. There are no review comments, and I have no additional feedback to provide.
Collaborator
Author
|
I pulled this out of your uv.lock PR. Those requirement() calls have bugged me for awhile, so i figured a good time to kill them. |
aignas
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use @dev_pip// format instead of the requirement() macro. This aligns with modern bzlmod patterns and simplifies the BUILD file.