test: Location expand environment variables

[hovind]

Description

Perform location expansion on testing environment.

Motivation

I want to provide paths to the scala_test via the environment. https://github.com/ucb-bar/chiseltest requires VERILATOR_ROOT to be present in the environment. I want to use the @verilator//:verilator_executable provided by https://github.com/hdl/bazel_rules_hdl.

I removed some ifs and elses whose necessity I did not quite understand, please advice if I have broken something.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[oharboe]

@simuons I'm running into this problem, any chance of having a look at this or some tips? 🤞

[simuons]

Hi @hovind could you rebase this PR on master? I need to refresh my memory to answer I removed some ifs and elses whose necessity I did not quite understand, please advice if I have broken something. and what was done in regards to env_inherit

@oharboe to unblock you I think you could replace phase_test_environment with custom phase. Please see https://github.com/bazel-contrib/rules_scala/tree/master#advanced-configurable-rules