Commit ae7df5a
committed
Add redacted_dates.h to assembler-files filegroup
PR #756 introduced date macro redaction by force-including a generated
redacted_dates.h header via the `-imacros` flag in unfiltered compile flags.
Since unfiltered compile flags are passed to all driver invocations (including
assembly compilations), clang tries to load this header when compiling
assembler (`.s` / `.S`) files.
However, redacted_dates.h was only declared as an input file in the C/C++
compiler-components filegroup, and was missing from the assembler-files
filegroup. This caused assembly compiles to fail with a fatal error:
"external/toolchains_llvm++llvm+llvm_toolchain/redacted_dates.h file not found"
as the header was absent from the assembler action's sandbox.
Fix this by adding redacted_dates.h to the assembler-files filegroup
definitions (both absolute-path and relative-path configurations) in
toolchain/internal/configure.bzl.
Also add a regression test compiling an empty assembly file to ensure the
assembler can successfully resolve redacted_dates.h.
Signed-off-by: Austin Schuh <austin.linux@gmail.com>1 parent 904cf9d commit ae7df5a
3 files changed
Lines changed: 14 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
313 | 313 | | |
314 | 314 | | |
315 | 315 | | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
695 | 695 | | |
696 | 696 | | |
697 | 697 | | |
698 | | - | |
| 698 | + | |
699 | 699 | | |
700 | 700 | | |
701 | 701 | | |
| |||
747 | 747 | | |
748 | 748 | | |
749 | 749 | | |
750 | | - | |
| 750 | + | |
751 | 751 | | |
752 | 752 | | |
753 | 753 | | |
| |||
0 commit comments