Skip to content

refactor: migrate to rules based toolchain#497

Open
thesayyn wants to merge 1 commit into
bazel-contrib:masterfrom
thesayyn:rules_based_toolchain
Open

refactor: migrate to rules based toolchain#497
thesayyn wants to merge 1 commit into
bazel-contrib:masterfrom
thesayyn:rules_based_toolchain

Conversation

@thesayyn

Copy link
Copy Markdown

WIP, #444

@thesayyn thesayyn force-pushed the rules_based_toolchain branch from 4248bd4 to f0ef928 Compare May 13, 2025 19:20
@fmeum

fmeum commented Jun 13, 2025

Copy link
Copy Markdown
Member

@thesayyn Sorry, I forgot about this. Is this ready for review?

@thesayyn

Copy link
Copy Markdown
Author

@fmeum its not close to being done, but i'd really appreciate the early feedback here. I am committed to land this and some more.

@fmeum

fmeum commented Jun 29, 2025

Copy link
Copy Markdown
Member

@thesayyn Took me a while not the general approach looks good to me.

I like to see a workaround for bazelbuild/rules_cc#277 - have you tried to upstream it?

This repo currently reuses the toolchain config from rules_cc. Is your plan to no longer do this or to also migrate the default toolchain to the new rules? Either would be fine, just curious.

@TroyKomodo

Copy link
Copy Markdown
Contributor

Ran into this issue when trying to fix toolchains_llvm to respect rules_sh posfix toolchain to replace #!/bin/bash with the correct path. From my perspective merging this PR will allow me to fix nixos builds.

@thesayyn is this PR stale? Would you mind if I continue the work here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants