Set canonical_id on sysroot download#799
Merged
dzbarsky merged 2 commits intoJul 11, 2026
Merged
Conversation
eloisekp
requested review from
dzbarsky,
fmeum,
helly25,
jsharpe and
rrbutani
as code owners
eloisekp
force-pushed
the
eloisekp/sysroot-use-canonical-id
branch
from
3b41ee8 to
7642aeb
Compare
rrbutani
reviewed
Jul 8, 2026
rrbutani
reviewed
Jul 8, 2026
dzbarsky
approved these changes
Jul 10, 2026
rrbutani
force-pushed
the
eloisekp/sysroot-use-canonical-id
branch
from
0075790 to
5993672
Compare
dzbarsky
approved these changes
Jul 10, 2026
rrbutani
force-pushed
the
eloisekp/sysroot-use-canonical-id
branch
from
5993672 to
49eb764
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sysrootrule doesn't passget_default_canonical_id()torctx.download(). Without it, the repo cache is keyed on the checksum alone, so changing a sysroot URL can serve stale cached bytes instead of refetching. This mirrorshttp_archive&http_filerules so a URL change forces a real download.See bazelbuild/bazel#22652 (comment)