Skip to content

Fix compiling assembly on OSX #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AustinSchuh wants to merge 3 commits into
base: master
Choose a base branch
from
+14 −3
Open

Fix compiling assembly on OSX #801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae7df5a
Add redacted_dates.h to assembler-files filegroup
AustinSchuh Jul 9, 2026
97a170c
Update libtinfo5 download URL to 6.3-2ubuntu0.2
AustinSchuh Jul 9, 2026
01ccf35
Formatting
AustinSchuh Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,3 +313,13 @@ cc_test(
tags = ["manual"],
deps = [":test_cxx_standard_lib_transitioned"],
)

cc_library(
name = "assembly_test_lib",
srcs = ["assembly_test.s"],
)

build_test(
name = "assembly_test",
targets = [":assembly_test_lib"],
)
1 change: 1 addition & 0 deletions tests/assembly_test.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# An empty assembly file to test that assembler action works
2 changes: 1 addition & 1 deletion tests/scripts/ubuntu_install_libtinfo.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ set -euo pipefail
pkg="$(mktemp --suffix=.deb)"
trap 'rm -f "${pkg}"' EXIT

curl -L https://mirrors.kernel.org/ubuntu/pool/universe/n/ncurses/libtinfo5_6.3-2ubuntu0.1_amd64.deb -o "${pkg}"
curl -L https://mirrors.kernel.org/ubuntu/pool/universe/n/ncurses/libtinfo5_6.3-2ubuntu0.2_amd64.deb -o "${pkg}"
sudo dpkg -i "${pkg}"
4 changes: 2 additions & 2 deletions toolchain/internal/configure.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ filegroup(

filegroup(name = "all-files-{suffix}", srcs = [":all-components-{suffix}", {extra_files_str}])
filegroup(name = "archiver-files-{suffix}", srcs = [{extra_files_str}])
filegroup(name = "assembler-files-{suffix}", srcs = [{extra_files_str}])
filegroup(name = "assembler-files-{suffix}", srcs = ["redacted_dates.h", {extra_files_str}])
filegroup(name = "compiler-files-{suffix}", srcs = [":compiler-components-{suffix}", {extra_files_str}])
filegroup(name = "dwp-files-{suffix}", srcs = [{extra_files_str}])
filegroup(name = "linker-files-{suffix}", srcs = [":linker-components-{suffix}", {extra_files_str}])
Expand Down Expand Up @@ -747,7 +747,7 @@ filegroup(

filegroup(name = "all-files-{suffix}", srcs = [":all-components-{suffix}", {extra_files_str}])
filegroup(name = "archiver-files-{suffix}", srcs = ["{llvm_dist_label_prefix}ar", {extra_files_str}])
filegroup(name = "assembler-files-{suffix}", srcs = ["{llvm_dist_label_prefix}as", {extra_files_str}])
filegroup(name = "assembler-files-{suffix}", srcs = ["{llvm_dist_label_prefix}as", "redacted_dates.h", {extra_files_str}])
filegroup(name = "compiler-files-{suffix}", srcs = [":compiler-components-{suffix}", {extra_files_str}])
filegroup(name = "dwp-files-{suffix}", srcs = ["{llvm_dist_label_prefix}dwp", {extra_files_str}])
filegroup(name = "linker-files-{suffix}", srcs = [":linker-components-{suffix}", {extra_files_str}])
Expand Down
Loading