Introduce basic support for xcode_config error message customization#594
Draft
aaronsky wants to merge 1 commit into
Draft
Introduce basic support for xcode_config error message customization#594aaronsky wants to merge 1 commit into
aaronsky wants to merge 1 commit into
Conversation
- Moved nearly all diagnostic messages in xcode_config to strings using named format fields - Moved the most basic, frequently occurring, `fail`ure messages into attrs on xcode_config - Updated docstrings
aaronsky
force-pushed
the
aaronsky/support-custom-xcode-config-error-messages
branch
from
c2b1483 to
23cef3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #568
failure messages into attrs on xcode_configI can expand this to support other
prints or incidentalfails, but for now I started with three of the most commonly encounteredfails.