Add fail_on_missing_constraint parameter to apple_support.platform_info_from_rule_ctx.#621
Open
keith wants to merge 1 commit into
Conversation
…info_from_rule_ctx. This allows callers to control whether a missing Apple platform constraint should result in a failure or a warning, or if a fallback should be silently applied, without the need to be on an allowlist. Generally this should be assumed "True" for rules-level logic as it can identify correctness issues quickly. However, users who want top level builds to default to Apple Silicon macOS as previous Apple fragment APIs allowed (albeit for Intel macOS) can still use the same API with this argument set to "False". PiperOrigin-RevId: 936570577 (cherry picked from commit ece6d2a)
keith
requested review from
aaronsky,
adincebic,
brentleyjones and
luispadron
as code owners
keith
referenced
this pull request
Jul 9, 2026
…info_from_rule_ctx. This allows callers to control whether a missing Apple platform constraint should result in a failure or a warning, or if a fallback should be silently applied, without the need to be on an allowlist. Generally this should be assumed "True" for rules-level logic as it can identify correctness issues quickly. However, users who want top level builds to default to Apple Silicon macOS as previous Apple fragment APIs allowed (albeit for Intel macOS) can still use the same API with this argument set to "False". PiperOrigin-RevId: 936570577
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows callers to control whether a missing Apple platform constraint should result in a failure or a warning, or if a fallback should be silently applied, without the need to be on an allowlist.
Generally this should be assumed "True" for rules-level logic as it can identify correctness issues quickly. However, users who want top level builds to default to Apple Silicon macOS as previous Apple fragment APIs allowed (albeit for Intel macOS) can still use the same API with this argument set to "False".
PiperOrigin-RevId: 936570577
(cherry picked from commit ece6d2a)