Skip to content

update pthreadpool to latest version and make it compatible with Bazel 8 platforms#6000

Merged
fmeum merged 14 commits into
bazelbuild:mainfrom
DoDoENT:update/pthreadpool
Sep 26, 2025
Merged

update pthreadpool to latest version and make it compatible with Bazel 8 platforms#6000
fmeum merged 14 commits into
bazelbuild:mainfrom
DoDoENT:update/pthreadpool

Conversation

@DoDoENT
Copy link
Copy Markdown
Contributor

@DoDoENT DoDoENT commented Sep 26, 2025

Note: This depends on this PR getting merged before.

@DoDoENT
Copy link
Copy Markdown
Contributor Author

DoDoENT commented Sep 26, 2025

@bazel-io skip_check unstable_url

@bazel-io
Copy link
Copy Markdown
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (pthreadpool) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Sep 26, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new version of the pthreadpool module, updating it to a recent commit and ensuring compatibility with modern Bazel platforms by providing a comprehensive BUILD.bazel overlay. The changes are well-structured and adhere to the Bazel Central Registry policies. My review includes one high-severity suggestion based on the repository's style guide to improve the long-term maintainability of the new module version.

Comment thread modules/pthreadpool/0.0.0-20250926-560c60d/overlay/BUILD.bazel Outdated
@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Sep 26, 2025
Comment thread modules/pthreadpool/0.0.0-20250926-560c60d/overlay/BUILD.bazel Outdated
@DoDoENT
Copy link
Copy Markdown
Contributor Author

DoDoENT commented Sep 26, 2025

Note: Upstream PR is here

@meteorcloudy
Copy link
Copy Markdown
Member

Please rebase your branch to get the latest version of cpuinfo

@DoDoENT
Copy link
Copy Markdown
Contributor Author

DoDoENT commented Sep 26, 2025

What's the deal with this error?


(12:00:04) ERROR: Traceback (most recent call last):
--
  | File "/private/var/tmp/_bazel_buildkite/9fd52dde456ed158c0e23ca9f82135f8/external/rules_foreign_cc+/toolchains/toolchains.bzl", line 44, column 25, in <toplevel>
  | current_cmake_toolchain = rule(
  | Error in rule: rule() got unexpected keyword argument 'incompatible_use_toolchain_transition'
  | (12:00:04) ERROR: /private/var/tmp/_bazel_buildkite/9fd52dde456ed158c0e23ca9f82135f8/external/pthreadpool+/BUILD.bazel:177:8: While resolving toolchains for target @@pthreadpool+//:pthreadpool_test (9b58834): invalid registered toolchain '@rules_foreign_cc//toolchains:built_make_toolchain': error loading package '@@rules_foreign_cc+//toolchains': initialization of module 'toolchains/toolchains.bzl' failed
  | (12:00:04) ERROR: Analysis of target '@@pthreadpool+//:pthreadpool_test' failed; build aborted

It happens only for Bazel rolling and points to somewhere within rules_foreign_cc, which are not used here at all.

@DoDoENT
Copy link
Copy Markdown
Contributor Author

DoDoENT commented Sep 26, 2025

It happens only for Bazel rolling and points to somewhere within rules_foreign_cc, which are not used here at all.

I removed the Bazel rolling tests for this module for the time being.

@fmeum fmeum enabled auto-merge (squash) September 26, 2025 11:42
@fmeum
Copy link
Copy Markdown
Contributor

fmeum commented Sep 26, 2025

@meteorcloudy

@meteorcloudy
Copy link
Copy Markdown
Member

It happens only for Bazel rolling and points to somewhere within rules_foreign_cc, which are not used here at all.

It's an incompatible change at HEAD, rules_foreign_cc must be fixed and upgraded.

@fmeum fmeum merged commit 29524ed into bazelbuild:main Sep 26, 2025
16 checks passed
@DoDoENT DoDoENT deleted the update/pthreadpool branch September 26, 2025 12:34
kotlaja pushed a commit to kotlaja/bazel-central-registry that referenced this pull request Oct 16, 2025
…l 8 platforms (bazelbuild#6000)

Note: This depends on [this
PR](bazelbuild#5991)
getting merged before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants