update pthreadpool to latest version and make it compatible with Bazel 8 platforms#6000
Conversation
|
@bazel-io skip_check unstable_url |
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (pthreadpool) have been updated in this PR. |
There was a problem hiding this comment.
Code Review
This pull request adds a new version of the pthreadpool module, updating it to a recent commit and ensuring compatibility with modern Bazel platforms by providing a comprehensive BUILD.bazel overlay. The changes are well-structured and adhere to the Bazel Central Registry policies. My review includes one high-severity suggestion based on the repository's style guide to improve the long-term maintainability of the new module version.
|
Note: Upstream PR is here |
|
Please rebase your branch to get the latest version of cpuinfo |
130ea51 to
e2515c0
Compare
|
What's the deal with this error? It happens only for Bazel rolling and points to somewhere within rules_foreign_cc, which are not used here at all. |
I removed the Bazel rolling tests for this module for the time being. |
It's an incompatible change at HEAD, rules_foreign_cc must be fixed and upgraded. |
…l 8 platforms (bazelbuild#6000) Note: This depends on [this PR](bazelbuild#5991) getting merged before.
Note: This depends on this PR getting merged before.