buildifier: honor exclude_patterns on Windows too

The `exclude_patterns` parameter passed to `buildifier` macros happens
to be ignored by the Windows runner script template, which the present
change proposes to address.

The change tries to adhere to existing choices, by limiting the impact
on `factory.bzl` where the `find`-suitable pattern can't be used by the
embedded powershell script, and also by respecting the script's style.

Author: rdesgroppes

buildifier/internal/factory.bzl

@@ -159,8 +159,12 @@ def buildifier_impl_factory(ctx, test_rule = False):
     if ctx.attr.exclude_patterns:
         if test_rule and not ctx.attr.no_sandbox:
             fail("Cannot use 'exclude_patterns' in a test rule without 'no_sandbox'")
-        exclude_patterns = ["\\! -path %s" % shell.quote(pattern) for pattern in ctx.attr.exclude_patterns]
-        exclude_patterns_str = " ".join(exclude_patterns)
+        if ctx.executable.buildifier.extension.lower() == "exe":
+            exclude_patterns = [shell.quote(pattern.replace("/", "\\")) for pattern in ctx.attr.exclude_patterns]
+            exclude_patterns_str = ", ".join(exclude_patterns)
+        else:
+            exclude_patterns = ["\\! -path %s" % shell.quote(pattern) for pattern in ctx.attr.exclude_patterns]
+            exclude_patterns_str = " ".join(exclude_patterns)
 
     workspace = ""
     if test_rule and ctx.attr.no_sandbox:

buildifier/runner.bat.template

@@ -12,10 +12,27 @@ rem Get the absolute path to the buildifier executable
 for /f "tokens=2" %%i in ('findstr /r "\<buildifier\.exe\>" MANIFEST') do (set buildifier_abs_path=%%i)
 
 powershell ^
+function Should-Exclude($Path)^
+{^
+    $relPath = '.' + $Path.Substring('%BUILD_WORKSPACE_DIRECTORY%'.Length);^
+    foreach ($pattern in @(@@EXCLUDE_PATTERNS@@))^
+    {^
+        if ($relPath -clike $pattern)^
+        {^
+            return $true;^
+        };^
+    };^
+    return $false;^
+};^
 function Buildify($Root)^
 {^
+    if (Should-Exclude $Root)^
+    {^
+        return;^
+    };^
     $Folder = (New-Object -Com Scripting.FileSystemObject).GetFolder($Root);^
     $Files = $Folder.Files ^| Where-Object {^
+        (^
         $_.Name -eq 'BUILD.bazel' `^
         -or $_.Name -eq 'BUILD' `^
         -or $_.Name -eq 'WORKSPACE' `^
@@ -28,6 +45,7 @@ function Buildify($Root)^
         -or $_.Name -clike 'BUILD.*.oss' `^
         -or $_.Name -clike 'WORKSPACE.*.bazel' `^
         -or $_.Name -clike 'WORKSPACE.*.oss'^
+        ) -and -not (Should-Exclude $_.Path)^
     };^
     foreach ($File in $Files)^
     {^
@@ -42,4 +60,4 @@ function Buildify($Root)^
         };^
     };^
 };^
-Buildify('%BUILD_WORKSPACE_DIRECTORY%');
+Buildify('%BUILD_WORKSPACE_DIRECTORY:/=\%');