Revert "updates (#1386)"#1471
Conversation
This reverts commit 4006b54.
There was a problem hiding this comment.
Code Review
This pull request removes the canonical-repository and external-path warning rules from buildifier's linter, including their documentation, configurations, implementations, and associated tests. Feedback indicates that the "warnings no duplicates" test case in buildifier/config/config_test.go (which is outside the current diff) still contains references to these removed warnings and needs to be updated to prevent test failures.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Buildtools PR checklist
Description
This reverts commit 4006b54. As reported in #1386 (comment) and below, this has numerous false positives and causes a lot of churn. The checks could potentially still be useful if scoped far more tightly, but determining this scope isn't trivial, hence a revert.