Skip to content

Revert "updates (#1386)"#1471

Open
fmeum wants to merge 2 commits into
bazelbuild:mainfrom
fmeum:revert
Open

Revert "updates (#1386)"#1471
fmeum wants to merge 2 commits into
bazelbuild:mainfrom
fmeum:revert

Conversation

@fmeum

@fmeum fmeum commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Buildtools PR checklist

  • The code in this PR is covered by unit/integration tests.
  • I have tested these changes and provide testing instructions below.
  • I have either responded to, or resolved all Gemini comments on the PR.
  • I have read Google Eng Practices on Small Changes, this PR either follows these guidelines or the description provides reasoning for why they can not be followed.

Description

This reverts commit 4006b54. As reported in #1386 (comment) and below, this has numerous false positives and causes a lot of churn. The checks could potentially still be useful if scoped far more tightly, but determining this scope isn't trivial, hence a revert.

@fmeum fmeum requested a review from a team as a code owner June 9, 2026 08:36
@fmeum fmeum requested review from vladmos and removed request for a team June 9, 2026 08:36
@fmeum

fmeum commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

@oreflow @Wyverald PTAL

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the canonical-repository and external-path warning rules from buildifier's linter, including their documentation, configurations, implementations, and associated tests. Feedback indicates that the "warnings no duplicates" test case in buildifier/config/config_test.go (which is outside the current diff) still contains references to these removed warnings and needs to be updated to prevent test failures.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread buildifier/config/config_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant