more fixes

Author: keith

mobile_install/apks.bzl

@@ -106,7 +106,26 @@ def make_split_apks(
         key_rotation_min_sdk,
         zipalign_alignment,
         sibling):
-    """Create a split for each dex and for resources"""
+    """Create a split for each dex and for resources.
+
+    Args:
+      ctx: The context.
+      manifest: The merged AndroidManifest.xml.
+      r_dex: The generated R dex artifact.
+      dexes: A list of dex artifacts to package as splits.
+      resource_apk: The resource APK.
+      jar_resources: Java resource jars to package.
+      native_zips: Native library zips to package.
+      swigdeps_file: A generated SWIG deps file.
+      debug_signing_keys: Debug keystores used to sign APKs.
+      debug_signing_lineage_file: File containing the signing lineage.
+      key_rotation_min_sdk: Minimum API level to rotate signing keys for.
+      zipalign_alignment: Zip alignment used before signing.
+      sibling: The file used to root generated outputs.
+
+    Returns:
+      A tuple of the manifest package-name file and the generated split APKs.
+    """
     manifest_package_name = utils.isolated_declare_file(ctx, "manifest_package_name.txt", sibling = sibling)
     manifests = {}
     artifacts = {}

mobile_install/mi.bzl

@@ -57,7 +57,9 @@ def make_aspect(
       dex_shards: Number of dex shards to split the project across.
       is_cmd: A Boolean, when True the aspect is running in the context of the
         mobile-install command. If False it is as a rule (e.g. mi_test).
+      is_test: Whether the aspect is running for a test rule.
       res_shards: Number of Android resource shards during processing.
+      tools: Tool attributes to attach to the aspect.
     Returns:
       A configured aspect.
     """

mobile_install/process.bzl

@@ -58,6 +58,7 @@ def process(
       debug_signing_keys: Debug keystores to be used to sign the apk.
       debug_signing_lineage_file: File containing the signing lineage.
       key_rotation_min_sdk: String of the minimum API level to rotate signing keys for.
+      zipalign_alignment: Zip alignment used before signing.
       apk: The generated apk for the app.
       sibling: The path to the launcher file.
 

mobile_install/resources.bzl

@@ -51,7 +51,15 @@ res_types = [
 ]
 
 def get_assets_dir(asset, base_dir):
-    """Build the full assets directory sanitizing the input first."""
+    """Build the full assets directory sanitizing the input first.
+
+    Args:
+      asset: The asset file or directory.
+      base_dir: The base assets directory.
+
+    Returns:
+      The sanitized assets directory path.
+    """
     if base_dir == "":
         # some targets specify assets files and set assets_dirs = ""
         return asset.dirname

mobile_install/transform.bzl

@@ -131,7 +131,7 @@ def merge_dex_shards(ctx, data, sibling):
     action per shard that runs dex_shard_merger on all dex files within that
     shard.
 
-    Arguments:
+    Args:
       ctx: The context.
       data: A list of lists, where the inner list contains dex shards.
       sibling: A file used to root the merged_dex shards.

prereqs.bzl

@@ -19,7 +19,11 @@ load("//bzlmod_extensions:apksig.bzl", _apksig_archive = "apksig")
 load("//bzlmod_extensions:com_android_dex.bzl", _com_android_dex_archive = "com_android_dex")
 
 def rules_android_prereqs(dev_mode = False):
-    """Downloads prerequisite repositories for rules_android."""
+    """Downloads prerequisite repositories for rules_android.
+
+    Args:
+      dev_mode: Whether to include development dependencies.
+    """
 
     maybe(
         http_archive,

providers/providers.bzl

@@ -125,6 +125,7 @@ InstrumentedAppInfo = provider(
 )
 
 FailureInfo = provider(
+    doc = "Provides failure information.",
     fields = dict(
         error = "Error message",
     ),

rules/aar_import/impl.bzl

@@ -52,8 +52,8 @@ ANDROID_MANIFEST = "AndroidManifest.xml"
 LINT_JAR = "lint.jar"
 
 # Resources context dict fields.
-_PROVIDERS = "providers"
-_VALIDATION_RESULTS = "validation_results"
+_PROVIDERS = "providers"  # @unused
+_VALIDATION_RESULTS = "validation_results"  # @unused
 
 def _create_aar_tree_artifact(ctx, name):
     return ctx.actions.declare_directory("%s/unzipped/%s/%s" % (RULE_PREFIX, name, ctx.label.name))
@@ -138,9 +138,9 @@ def _process_resources(
         aar,
         package,
         manifest,
-        deps,
+        deps,  # @unused
         aar_resources_extractor_tool,
-        unzip_tool):
+        unzip_tool):  # @unused
     # Extract resources and assets, if they exist.
     resources = _create_aar_tree_artifact(ctx, "resources")
     assets = _create_aar_tree_artifact(ctx, "assets")

rules/acls.bzl

@@ -310,11 +310,21 @@ BYTECODE_TRANSFORMERS_DICT = make_dict(BYTECODE_TRANSFORMERS)
 AAR_IMPORT_PROPAGATE_NATIVE_LIBS_FALLBACK_DICT = make_dict(AAR_IMPORT_PROPAGATE_NATIVE_LIBS_FALLBACK)
 
 def matches(fqn, dct):
+    """Returns whether a fully qualified label matches an ACL dictionary.
+
+    Args:
+      fqn: The fully qualified label to match.
+      dct: The ACL dictionary.
+
+    Returns:
+      True if the label matches the ACL dictionary.
+    """
+
     # Labels with workspace names ("@workspace//pkg:target") are not supported.
     # For now, default external dependency ACLs to True to enable rollout features for all
     # external users. See https://github.com/bazelbuild/rules_android/issues/68
     # Note that this only affects Bazel builds with OSS rules_android.
-    if fqn.startswith("@") and not fqn.startswith("@//") and not fqn.startswith("@@//"):
+    if fqn.startswith("@") and not fqn.startswith("@//") and not fqn.startswith("@@//"):  # buildifier: disable=canonical-repository
         return True
 
     # "@//" is the same as the main workspace. It's not completely accurate to treat these as
@@ -325,7 +335,7 @@ def matches(fqn, dct):
         fqn = fqn[1:]
 
     # "@@//" refers to the canonical name of the main repository.
-    if fqn.startswith("@@//"):
+    if fqn.startswith("@@//"):  # buildifier: disable=canonical-repository
         fqn = fqn[2:]
 
     if not fqn.startswith("//"):

rules/android_application/android_application_rule.bzl

@@ -187,8 +187,8 @@ def _create_feature_manifest(
         aapt2,
         feature_manifest_script,
         priority_feature_manifest_script,
-        android_resources_busybox,
-        host_javabase):
+        android_resources_busybox,  # @unused
+        host_javabase):  # @unused
     info = feature_target[AndroidFeatureModuleInfo]
     manifest = ctx.actions.declare_file(ctx.label.name + "/" + feature_target.label.name + "/AndroidManifest.xml")