Add use_minimal_keep_rules flag for aapt2 minimal proguard keep rules#538
Open
Dolfik1 wants to merge 1 commit into
Open
Add use_minimal_keep_rules flag for aapt2 minimal proguard keep rules#538Dolfik1 wants to merge 1 commit into
use_minimal_keep_rules flag for aapt2 minimal proguard keep rules#538Dolfik1 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
1dbb9e2 to
ab83d1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
aapt2 generates broad resource keep rules by default. Bazel and Gradle produce different rules for the same target:
Gradle passes
--proguard-minimal-keep-rulesto aapt2, emitting precise member signatures. Bazel does not, so keep rules (and shrinking output) diverge.Change
Add opt-in flag
use_minimal_keep_rules. When enabled, aapt2linkreceives--proguard-minimal-keep-rules, matching Gradle.Off by default. Enable with:
Mirrors the existing
conditionalKeepRules/--proguard-conditional-keep-rulespath.