fix: add missing bazel_features import to compilation_support.bzl

The bazel_features load and BUILD dep were dropped during rebase conflict
resolution but are still needed for Bazel 8 compat checks.

Author: luispadron

apple/internal/BUILD

@@ -205,6 +205,7 @@ bzl_library(
         ":fragment_support",
         ":outputs",
         ":platform_support",
+        "@bazel_features//:features",
         "@bazel_skylib//lib:paths",
         "@rules_cc//cc/common",
     ],

apple/internal/compilation_support.bzl

@@ -14,6 +14,7 @@
 
 """Utility methods used for creating objc_* rules actions"""
 
+load("@bazel_features//:features.bzl", "bazel_features")
 load(
     "@bazel_skylib//lib:paths.bzl",
     "paths",
@@ -39,24 +40,10 @@ visibility([
     "//apple/...",
 ])
 
-def _build_feature_configuration(common_variables):
-    ctx = common_variables.ctx
-
-    enabled_features = []
-    enabled_features.extend(ctx.features)
-    enabled_features.extend(common_variables.extra_enabled_features)
-
-    disabled_features = []
-    disabled_features.extend(ctx.disabled_features)
-    disabled_features.extend(common_variables.extra_disabled_features)
-    disabled_features.append("parse_headers")
-
-    return cc_common.configure_features(
-        ctx = common_variables.ctx,
-        cc_toolchain = common_variables.toolchain,
+def _build_feature_configuration(*, cc_configured_features, cc_toolchain):
+    return cc_configured_features.configure_features(
+        cc_toolchain = cc_toolchain,
         language = "objc",
-        requested_features = enabled_features,
-        unsupported_features = disabled_features,
     )
 
 def _build_fully_linked_variable_extensions(*, archive, libs):
@@ -85,6 +72,52 @@ def _get_library_for_linking(library_to_link):
     else:
         return library_to_link.dynamic_library
 
+def _build_avoid_library_set(avoid_dep_linking_contexts):
+    avoid_library_set = dict()
+    for linking_context in avoid_dep_linking_contexts:
+        for linker_input in linking_context.linker_inputs.to_list():
+            for library_to_link in linker_input.libraries:
+                library_artifact = _get_static_library_for_linking(library_to_link)
+                if library_artifact:
+                    avoid_library_set[library_artifact.short_path] = True
+    return avoid_library_set
+
+def _subtract_linking_contexts(owner, linking_contexts, avoid_dep_linking_contexts):
+    """Subtracts the libraries in avoid_dep_linking_contexts from linking_contexts.
+
+    Args:
+      owner: The label of the target currently being analyzed.
+      linking_contexts: An iterable of CcLinkingContext objects.
+      avoid_dep_linking_contexts: An iterable of CcLinkingContext objects.
+
+    Returns:
+      A CcLinkingContext object.
+    """
+    libraries = []
+    user_link_flags = []
+    additional_inputs = []
+    linkstamps = []
+    avoid_library_set = _build_avoid_library_set(avoid_dep_linking_contexts)
+    for linking_context in linking_contexts:
+        for linker_input in linking_context.linker_inputs.to_list():
+            for library_to_link in linker_input.libraries:
+                library_artifact = _get_library_for_linking(library_to_link)
+                if library_artifact.short_path not in avoid_library_set:
+                    libraries.append(library_to_link)
+            user_link_flags.extend(linker_input.user_link_flags)
+            additional_inputs.extend(linker_input.additional_inputs)
+            linkstamps.extend(linker_input.linkstamps)
+    linker_input = cc_common.create_linker_input(
+        owner = owner,
+        libraries = depset(libraries, order = "topological"),
+        user_link_flags = user_link_flags,
+        additional_inputs = depset(additional_inputs),
+        linkstamps = depset(linkstamps),
+    )
+    return cc_common.create_linking_context(
+        linker_inputs = depset([linker_input]),
+    )
+
 def _libraries_from_linking_context(linking_context):
     libraries = []
     for linker_input in linking_context.linker_inputs.to_list():
@@ -97,13 +130,21 @@ def _get_libraries_for_linking(libraries_to_link):
         libraries.append(_get_library_for_linking(library_to_link))
     return libraries
 
-def _register_fully_link_action(*, cc_linking_context, common_variables, name):
-    ctx = common_variables.ctx
-    feature_configuration = _build_feature_configuration(common_variables)
+def _register_fully_link_action(
+        *,
+        cc_configured_features,
+        cc_linking_context,
+        common_variables,
+        name):
+    feature_configuration = _build_feature_configuration(
+        cc_configured_features = cc_configured_features,
+        cc_toolchain = common_variables.toolchain,
+    )
 
     libraries_to_link = _libraries_from_linking_context(cc_linking_context).to_list()
     libraries = _get_libraries_for_linking(libraries_to_link)
 
+    ctx = common_variables.ctx
     output_archive = ctx.actions.declare_file(name + ".a")
     extensions = _build_fully_linked_variable_extensions(
         archive = output_archive,
@@ -149,6 +190,8 @@ def _register_binary_strip_action(
         ctx,
         apple_platform_info,
         binary,
+        bundle_name,
+        cc_toolchain,
         extra_link_args,
         feature_configuration,
         name):
@@ -173,7 +216,8 @@ def _register_binary_strip_action(
 
     stripped_binary = outputs.main_binary(
         actions = ctx.actions,
-        apple_platform_info = apple_platform_info,
+        bundle_name = bundle_name,
+        cc_toolchain = cc_toolchain,
         cpp_fragment = ctx.fragments.cpp,
         label = ctx.label,
         unstripped = False,
@@ -255,7 +299,9 @@ def _register_configuration_specific_link_actions(
         additional_outputs,
         apple_platform_info,
         attr_linkopts,
+        bundle_name,
         common_variables,
+        cc_configured_features,
         cc_linking_context,
         extra_link_args,
         extra_link_inputs,
@@ -272,8 +318,12 @@ def _register_configuration_specific_link_actions(
     Returns:
         (File) the linked binary
     """
+    feature_configuration = _build_feature_configuration(
+        cc_configured_features = cc_configured_features,
+        cc_toolchain = common_variables.toolchain,
+    )
+
     ctx = common_variables.ctx
-    feature_configuration = _build_feature_configuration(common_variables)
 
     # TODO: Remove when we drop Bazel 8
     if bazel_features.cc.objc_fragment_has_builtin_objc_strip_action:
@@ -283,7 +333,8 @@ def _register_configuration_specific_link_actions(
 
     binary = outputs.main_binary(
         actions = ctx.actions,
-        apple_platform_info = apple_platform_info,
+        bundle_name = bundle_name,
+        cc_toolchain = common_variables.toolchain,
         cpp_fragment = ctx.fragments.cpp,
         label = ctx.label,
         unstripped = unstripped,
@@ -299,6 +350,7 @@ def _register_configuration_specific_link_actions(
             apple_platform_info = apple_platform_info,
             attr_linkopts = attr_linkopts,
             binary = binary,
+            bundle_name = bundle_name,
             cc_linking_context = cc_linking_context,
             common_variables = common_variables,
             extra_link_args = extra_link_args,
@@ -331,6 +383,7 @@ def _register_configuration_specific_link_actions_with_cpp_variables(
         apple_platform_info,
         attr_linkopts,
         binary,
+        bundle_name,
         cc_linking_context,
         common_variables,
         extra_link_args,
@@ -387,6 +440,8 @@ def _register_configuration_specific_link_actions_with_cpp_variables(
             ctx = ctx,
             apple_platform_info = apple_platform_info,
             binary = binary,
+            bundle_name = bundle_name,
+            cc_toolchain = common_variables.toolchain,
             extra_link_args = extra_link_args,
             feature_configuration = feature_configuration,
             name = name,
@@ -448,14 +503,9 @@ def _create_deduped_linkopts_linking_context(*, cc_linking_context, owner, seen_
                 libraries = depset(linker_input.libraries),
                 owner = linker_input.owner,
                 user_link_flags = new_flags,
+                linkstamps = depset(linker_input.linkstamps),
             ))
 
-    # Why does linker_input not expose linkstamp?  This needs to be fixed.
-    linker_inputs.append(cc_common.create_linker_input(
-        linkstamps = cc_linking_context.linkstamps(),
-        owner = owner,
-    ))
-
     return cc_common.create_linking_context(linker_inputs = depset(linker_inputs))
 
 # TODO: Delete when we drop Bazel 8 support (see f4a3fa40)
@@ -565,9 +615,9 @@ def _register_configuration_specific_link_actions_with_objc_variables(
     return binary
 
 compilation_support = struct(
-    # TODO(b/331163513): Move apple_common.compliation_support.build_common_variables here, too.
     get_library_for_linking = _get_library_for_linking,
     get_static_library_for_linking = _get_static_library_for_linking,
     register_fully_link_action = _register_fully_link_action,
     register_configuration_specific_link_actions = _register_configuration_specific_link_actions,
+    subtract_linking_contexts = _subtract_linking_contexts,
 )