Skip to content

Replace apple_common.compilation_support.build_common_variables with rules_cc version #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brentleyjones wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace apple_common.compilation_support.build_common_variables with rules_cc version #2862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
262b066
Replace `apple_common.compilation_support.build_common_variables` wit…
comius Oct 28, 2025
3e5fd99
Lint
brentleyjones Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apple/internal/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,7 @@ bzl_library(
":rule_support",
"@bazel_skylib//lib:collections",
"@build_bazel_apple_support//lib:lipo",
"@rules_cc//cc/private/rules_impl:objc_compilation_support_bzl",
],
)

Expand Down
8 changes: 6 additions & 2 deletions apple/internal/linking_support.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ load(
load("@build_bazel_apple_support//lib:lipo.bzl", "lipo")
load("@rules_cc//cc/common:cc_common.bzl", "cc_common")
load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
load(
"@rules_cc//cc/private/rules_impl:objc_compilation_support.bzl",
objc_compilation_support = "compilation_support",
) # buildifier: disable=bzl-visibility
load(
"//apple/internal:cc_toolchain_info_support.bzl",
"cc_toolchain_info_support",
Expand Down Expand Up @@ -78,7 +82,7 @@ def _archive_multi_arch_static_library(

for split_transition_key, child_toolchain in cc_toolchains.items():
cc_toolchain = child_toolchain[cc_common.CcToolchainInfo]
common_variables = apple_common.compilation_support.build_common_variables(
common_variables = objc_compilation_support.build_common_variables(
ctx = ctx,
toolchain = cc_toolchain,
use_pch = True,
Expand Down Expand Up @@ -245,7 +249,7 @@ def _link_multi_arch_binary(
deps = split_deps.get(split_transition_key, [])
platform_info = child_toolchain[ApplePlatformInfo]

common_variables = apple_common.compilation_support.build_common_variables(
common_variables = objc_compilation_support.build_common_variables(
ctx = ctx,
toolchain = cc_toolchain,
deps = deps,
Expand Down