Fix iOS simulator leakage on test timeout (#2986)#3005
Open
mansiverma897993 wants to merge 1 commit into
Open
Conversation
Clean up simulators and temporary directories when the test runner is aborted due to a timeout (receiving SIGTERM/SIGINT) by trapping these signals and setting a TEST_TIMEOUT_DETECTED environment variable for the cleanup script. Modify the default cleanup script to delete the simulator if it timed out, even if reuse is enabled.
mansiverma897993
requested review from
aaronsky,
adincebic,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| fi | ||
|
|
||
| if [ -z "${SIMULATOR_REUSE_SIMULATOR:-}" ]; then | ||
| if [ -z "${SIMULATOR_REUSE_SIMULATOR:-}" ] || [ -n "${TEST_TIMEOUT_DETECTED:-}" ]; then |
Contributor
There was a problem hiding this comment.
If the simulator is being shared between tests won't deleting it when a single test times out cause a bunch of unrelated failures?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up simulators and temporary directories when the test runner is aborted due to a timeout (receiving SIGTERM/SIGINT) by trapping these signals and setting a TEST_TIMEOUT_DETECTED environment variable for the cleanup script. Modify the default cleanup script to delete the simulator if it timed out, even if reuse is enabled.