Skip to content

Remove bazel_features extension_metadata use #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keith wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −18
Open

Remove bazel_features extension_metadata use #3018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apple/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ bzl_library(
"//apple/internal:apple_xcframework_import",
"//apple/internal:local_provisioning_profiles",
"//apple/internal:xcframework_rules",
"@bazel_features//:features",
"@rules_cc//cc:find_cc_toolchain_bzl",
"@rules_cc//cc/common",
],
Expand Down
10 changes: 1 addition & 9 deletions apple/extensions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,10 @@

"""Definitions for bzlmod module extensions."""

load("@bazel_features//:features.bzl", "bazel_features")
load("//apple/internal:repositories.bzl", "apple_rules_dependencies")

def _non_module_deps_impl(module_ctx):
apple_rules_dependencies()

metadata_kwargs = {}
if bazel_features.external_deps.extension_metadata_has_reproducible:
metadata_kwargs["reproducible"] = True

return module_ctx.extension_metadata(
**metadata_kwargs
)
return module_ctx.extension_metadata(reproducible = True)

non_module_deps = module_extension(implementation = _non_module_deps_impl)
9 changes: 1 addition & 8 deletions apple/internal/local_provisioning_profiles.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"""# Rules for using locally installed provisioning profiles"""

load("@bazel_features//:features.bzl", "bazel_features")
load(
"//apple:providers.bzl",
"AppleProvisioningProfileInfo",
Expand Down Expand Up @@ -122,13 +121,7 @@ def _provisioning_profile_repository_extension(module_ctx):
**kwargs
)

metadata_kwargs = {}
if bazel_features.external_deps.extension_metadata_has_reproducible:
metadata_kwargs["reproducible"] = True

return module_ctx.extension_metadata(
**metadata_kwargs
)
return module_ctx.extension_metadata(reproducible = True)

provisioning_profile_repository_extension = module_extension(
implementation = _provisioning_profile_repository_extension,
Expand Down