Skip to content

Commit 934c1b2

Browse files
hvadehrarules_java Copybara
authored andcommitted
Fix proto_support.bzl for Bazel
Work towards bazelbuild/bazel#24543 PiperOrigin-RevId: 702587292 Change-Id: I5feb477d86c059008ed78b58588a7a6fe7976e20
1 parent 36a3669 commit 934c1b2

5 files changed

Lines changed: 29 additions & 19 deletions

File tree

java/common/rules/basic_java_library.bzl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@ load("//java/private:java_common.bzl", "java_common")
2121
load("//java/private:java_info.bzl", "JavaPluginInfo")
2222
load(":rule_util.bzl", "merge_attrs")
2323

24-
visibility([
25-
"//java/...",
26-
])
24+
# copybara: default multiline visibility
2725

2826
BASIC_JAVA_LIBRARY_IMPLICIT_ATTRS = merge_attrs(
2927
{

java/common/rules/impl/basic_java_library_impl.bzl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ load("//java/private:java_info.bzl", "JavaInfo", "JavaPluginInfo")
2424
load(":compile_action.bzl", "compile_action")
2525
load(":proguard_validation.bzl", "validate_proguard_specs")
2626

27-
visibility([
28-
"//java/...",
29-
])
27+
# copybara: default multiline visibility
3028

3129
def _filter_srcs(srcs, ext):
3230
return [f for f in srcs if f.extension == ext]

java/private/java_common_internal.bzl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@ load(
2727
)
2828
load(":native.bzl", "get_internal_java_common")
2929

30-
visibility([
31-
"//java/...",
32-
])
30+
# copybara: default multiline visibility
3331

3432
def compile(
3533
ctx,

java/private/proto_support.bzl

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,25 @@
1313
# limitations under the License.
1414
"""Support for Java compilation of protocol buffer generated code."""
1515

16-
load("@compatibility_proxy//:proxy.bzl", "java_common")
16+
load("@compatibility_proxy//:proxy.bzl", "java_common", "java_common_internal_compile", "java_info_internal_merge")
1717

18-
# Partial support, because internal symbols are not available in older Bazel version
19-
# TODO: Once Java rules are moved into the rules_java, this should become a full support.
18+
def compile(*, injecting_rule_kind, enable_jspecify, include_compilation_info, **kwargs):
19+
if java_common_internal_compile:
20+
return java_common_internal_compile(
21+
injecting_rule_kind = injecting_rule_kind,
22+
enable_jspecify = enable_jspecify,
23+
include_compilation_info = include_compilation_info,
24+
**kwargs
25+
)
26+
else:
27+
return java_common.compile(**kwargs)
2028

21-
def compile(*, injecting_rule_kind, enable_jspecify, include_compilation_info, **kwargs): # buildifier: disable=unused-variable
22-
return java_common.compile(**kwargs)
23-
24-
def merge(providers, *, merge_java_outputs = True, merge_source_jars = True): # buildifier: disable=unused-variable
25-
return java_common.merge(providers)
29+
def merge(providers, *, merge_java_outputs = True, merge_source_jars = True):
30+
if java_info_internal_merge:
31+
return java_info_internal_merge(
32+
providers,
33+
merge_java_outputs = merge_java_outputs,
34+
merge_source_jars = merge_source_jars,
35+
)
36+
else:
37+
return java_common.merge(providers)

java/rules_java_deps.bzl

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ load("@rules_java//java/common/rules:java_package_configuration.bzl", _java_pack
3737
load("@rules_java//java/common/rules:java_runtime.bzl", _java_runtime = "java_runtime")
3838
load("@rules_java//java/common/rules:java_toolchain.bzl", _java_toolchain = "java_toolchain")
3939
load("@rules_java//java/private:java_common.bzl", _java_common = "java_common")
40-
load("@rules_java//java/private:java_info.bzl", _JavaInfo = "JavaInfo", _JavaPluginInfo = "JavaPluginInfo")
40+
load("@rules_java//java/private:java_common_internal.bzl", _java_common_internal_compile = "compile")
41+
load("@rules_java//java/private:java_info.bzl", _JavaInfo = "JavaInfo", _JavaPluginInfo = "JavaPluginInfo", _java_info_internal_merge = "merge")
4142
load("@rules_java//java:http_jar.bzl", _http_jar = "http_jar")
4243
4344
java_binary = _java_binary
@@ -51,7 +52,8 @@ java_toolchain = _java_toolchain
5152
java_common = _java_common
5253
JavaInfo = _JavaInfo
5354
JavaPluginInfo = _JavaPluginInfo
54-
55+
java_common_internal_compile = _java_common_internal_compile
56+
java_info_internal_merge = _java_info_internal_merge
5557
http_jar = _http_jar
5658
""",
5759
)
@@ -91,6 +93,8 @@ java_toolchain = native.java_toolchain
9193
java_common = native_java_common
9294
JavaInfo = NativeJavaInfo
9395
JavaPluginInfo = NativeJavaPluginInfo
96+
java_common_internal_compile = None
97+
java_info_internal_merge = None
9498
9599
http_jar = _http_jar
96100
""",

0 commit comments

Comments
 (0)