Don't attempt to enable the Security Manager for jdk >= 24

hvadehra · rules_java Copybara · commit b3a0580e0a9a · 2024-12-09T09:05:32.000-08:00
The Security Manager is being permanently disabled in JDK 24, see https://openjdk.org/jeps/486 PiperOrigin-RevId: 704307132 Change-Id: I95501503206a85b6d9f828c4c6ab8e1fb3313eef
diff --git a/java/bazel/rules/bazel_java_binary.bzl b/java/bazel/rules/bazel_java_binary.bzl
@@ -75,7 +75,8 @@ def bazel_base_binary_impl(ctx, is_test_rule_class):
     )
 
     if ctx.attr.use_testrunner:
-        if semantics.find_java_runtime_toolchain(ctx).version >= 17:
+        _java_runtime_version = semantics.find_java_runtime_toolchain(ctx).version
+        if _java_runtime_version >= 17 and _java_runtime_version < 24:
             jvm_flags.append("-Djava.security.manager=allow")
         test_class = ctx.attr.test_class if hasattr(ctx.attr, "test_class") else ""
         if test_class == "":

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,8 @@ def bazel_base_binary_impl(ctx, is_test_rule_class):`
`75`	`75`	`)`
`76`	`76`
`77`	`77`	`if ctx.attr.use_testrunner:`
`78`		`- if semantics.find_java_runtime_toolchain(ctx).version >= 17:`
	`78`	`+ _java_runtime_version = semantics.find_java_runtime_toolchain(ctx).version`
	`79`	`+ if _java_runtime_version >= 17 and _java_runtime_version < 24:`
`79`	`80`	`jvm_flags.append("-Djava.security.manager=allow")`
`80`	`81`	`test_class = ctx.attr.test_class if hasattr(ctx.attr, "test_class") else ""`
`81`	`82`	`if test_class == "":`