Add a test for java_common.compile() with a custom bootclasspathinfo and empty bootclasspath

PiperOrigin-RevId: 729522132
Change-Id: Ib49f848211c8b2f83f42c5cd9e82ffdb1505c85d

Author: hvadehra

java/test/common/java_common_tests.bzl

@@ -163,14 +163,16 @@ def _test_compile_extend_compile_time_jdeps_rule_outputs_impl(env, targets):
     ])
 
 def _test_compile_bootclasspath(name):
+    files = [
+        "custom-system/lib/jrt-fs.jar",
+        "custom-system/lib/modules",
+        "custom-system/release",
+    ]
     util.helper_target(
         custom_bootclasspath,
         name = name + "/bootclasspath",
-        srcs = [
-            "custom-system/lib/jrt-fs.jar",
-            "custom-system/lib/modules",
-            "custom-system/release",
-        ],
+        bootclasspath = files,
+        system = files,
     )
     util.helper_target(
         custom_library_with_bootclasspath,
@@ -197,6 +199,39 @@ def _test_compile_bootclasspath_impl(env, target):
         "{}/custom-system".format(target.label.package),
     )])
 
+def _test_compile_override_with_empty_bootclasspath(name):
+    util.helper_target(
+        custom_bootclasspath,
+        name = name + "/bootclasspath",
+        bootclasspath = [],
+        system = [
+            "custom-system/lib/jrt-fs.jar",
+            "custom-system/lib/modules",
+            "custom-system/release",
+        ],
+    )
+    util.helper_target(
+        custom_library_with_bootclasspath,
+        name = name + "/custom",
+        srcs = ["Main.java"],
+        bootclasspath = name + "/bootclasspath",
+    )
+
+    analysis_test(
+        name = name,
+        impl = _test_compile_override_with_empty_bootclasspath_impl,
+        target = name + "/custom",
+        attr_values = {"tags": ["min_bazel_7"]},
+    )
+
+def _test_compile_override_with_empty_bootclasspath_impl(env, target):
+    assert_that_javac = env.expect.that_target(target).action_named("Javac")
+
+    assert_that_javac.contains_flag_values([(
+        "--system",
+        "{}/custom-system".format(target.label.package),
+    )])
+
 def java_common_tests(name):
     test_suite(
         name = name,
@@ -208,5 +243,6 @@ def java_common_tests(name):
             _test_compile_extend_compile_time_jdeps,
             _test_compile_extend_compile_time_jdeps_rule_outputs,
             _test_compile_bootclasspath,
+            _test_compile_override_with_empty_bootclasspath,
         ],
     )

java/test/testutil/rules/custom_library_with_bootclasspath.bzl

@@ -4,13 +4,13 @@ load("//java/common:java_common.bzl", "java_common")
 load("//java/common:java_semantics.bzl", "semantics")
 
 def _bootclasspath(ctx):
-    files = ctx.files.srcs
-    return [java_common.BootClassPathInfo(bootclasspath = files, system = files)]
+    return [java_common.BootClassPathInfo(bootclasspath = ctx.files.bootclasspath, system = ctx.files.system)]
 
 custom_bootclasspath = rule(
     implementation = _bootclasspath,
     attrs = {
-        "srcs": attr.label_list(allow_files = True),
+        "bootclasspath": attr.label_list(allow_files = True),
+        "system": attr.label_list(allow_files = True),
     },
 )