Add more sysroot flags that require prefixing#4101
Open
keith wants to merge 1 commit into
Open
Conversation
keith
changed the title
dan-stowell
added a commit
to dan-stowell/bazel-museum
that referenced
this pull request
Jun 25, 2026
rules_rust: backport bazelbuild/rules_rust#4101 (= hermeticbuild/rules_rust#30) onto rules_rust 0.68.1, unforked, via a single_version_override patch (new RULES_RUST_SYSROOT_FIX overlay, applied to cxx alongside HERMETIC_LLVM). cargo build scripts rewrite execroot-relative sysroot paths to ${pwd}/... so they work under remote execution, but 0.68.1 only handled `--sysroot=<path>` — not the `-isysroot <path>` (two args) that hermetic-llvm now emits on macOS after our #642 backport. So the museum's own hermetic-llvm fix is what surfaced this; the patch makes Rust+macOS builds work without waiting for the PRs to land. Patch verified to apply (dry-run + inner module resolution). Shared repository cache: the macOS SDK (and the hermetic LLVM tarballs) were re-downloaded per goal because each goal had its own repo cache, which trips Apple's CDN rate limit (429/403) and intermittently fails darwin builds. Point every goal at one content-addressed repo cache under the museum base instead: safe (hash-keyed) and exactly its purpose — fetch once, reuse everywhere. The per-goal output_user_root, fresh source, scrubbed env and --batch are unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.