Skip to content

Commit 2154f50

Browse files
Fix distroVersion if unknown version in VMWARE
File "/opt/netbox-sync/module/sources/vmware/connection.py", line 2200, in add_virtual_machine detailed_data_dict.get("distroVersion") not in platform: TypeError: 'in <string>' requires string as left operand, not NoneType Fixes this error, this seemed to be when a OS version is not known in VMWare.
1 parent 9870c44 commit 2154f50

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

module/sources/vmware/connection.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2196,9 +2196,14 @@ def add_virtual_machine(self, obj):
21962196
detailed_data_dict[detailed_data_key] = detailed_data_value.strip("'")
21972197
if len(detailed_data_dict.get("prettyName","")) > 0:
21982198
platform = detailed_data_dict.get("prettyName")
2199-
if detailed_data_dict.get("familyName", "").lower() == "linux" and \
2200-
detailed_data_dict.get("distroVersion") not in platform:
2201-
platform = f'{platform} {detailed_data_dict.get("distroVersion")}'
2199+
2200+
distro_version = detailed_data_dict.get("distroVersion")
2201+
if detailed_data_dict.get("familyName", "").lower() == "linux" and distro_version:
2202+
if distro_version not in platform:
2203+
platform = f'{platform} {distro_version}'
2204+
if platform is not None:
2205+
platform = self.get_object_relation(platform, "vm_platform_relation", fallback=platform)
2206+
22022207

22032208
if platform is not None:
22042209
platform = self.get_object_relation(platform, "vm_platform_relation", fallback=platform)

0 commit comments

Comments
 (0)