should prevent changing attributes with same data #245 #275

Author: bb-Ricardo

README.md

@@ -317,9 +317,8 @@ type = check_redfish
 inventory_file_path = /opt/redfish_inventory
 ```
 
-**Developers**:
-If you are interested in adding more source types please open an issue/discussion
-because the documentation of implementing a new source hasn't been finished yet. 🤷
+If different sources overwrite the same attribute for ex. a host then the order of the sources should be considered.
+The last source in order from top to bottom will prevail. 
 
 ## Pruning
 Prune objects in NetBox if they are no longer present in any source.

module/netbox/object_classes.py

@@ -279,6 +279,7 @@ def __init__(self, data=None, read_from_netbox=False, inventory=None, source=Non
         self.unset_items = list()
         self.source = source
         self.deleted = False
+        self._original_data = dict()
 
         # add empty lists for list items
         for key, data_type in self.data_model.items():
@@ -612,15 +613,29 @@ def update(self, data=None, read_from_netbox=False, source=None):
             if key == self.primary_key and current_value_str.lower() == new_value_str.lower():
                 continue
 
-            self.data[key] = new_value
-            self.updated_items.append(key)
-            data_updated = True
-
             if self.is_new is False:
+
+                if self._original_data.get(key) == new_value_str and key in self.updated_items:
+                    self.data[key] = new_value
+                    self.updated_items.remove(key)
+                    log.debug(f"{self.name.capitalize()} '{display_name}' attribute '{key}' was set back to "
+                              f"original NetBox value '{current_value_str}'")
+                    continue
+
+                # save original NetBox value for future use to detect updates which sets it back to the same value
+                # which is already saved in NetBox
+                elif self._original_data.get(key) is None:
+                    self._original_data[key] = current_value_str
+                    print(self._original_data[key])
+
                 new_value_str = new_value_str.replace("\n", " ")
                 log.info(f"{self.name.capitalize()} '{display_name}' attribute '{key}' changed from "
                          f"'{current_value_str}' to '{new_value_str}'")
 
+            self.data[key] = new_value
+            self.updated_items.append(key)
+            data_updated = True
+
             self.resolve_relations()
 
         if data_updated is True and self.is_new is False: