fixes issue with revers lookups and python 3.14 #499

Author: bb-Ricardo

module/common/support.py

@@ -44,7 +44,7 @@ def normalize_mac_address(mac_address=None):
     return mac_address
 
 
-def perform_ptr_lookups(ips, dns_servers=None):
+async def perform_ptr_lookups(ips, dns_servers=None):
     """
     Perform DNS reverse lookups for IP addresses to find corresponding DNS name
 
@@ -60,9 +60,7 @@ def perform_ptr_lookups(ips, dns_servers=None):
     dict: of {"ip": "hostname"} for requested ips, hostname will be None if no hostname returned
     """
 
-    loop = asyncio.get_event_loop()
-
-    resolver = aiodns.DNSResolver(loop=loop)
+    resolver = aiodns.DNSResolver()
 
     if dns_servers is not None:
         if isinstance(dns_servers, list):
@@ -71,8 +69,12 @@ def perform_ptr_lookups(ips, dns_servers=None):
         else:
             log.error(f"List of provided DNS servers invalid: {dns_servers}")
 
-    queue = asyncio.gather(*(reverse_lookup(resolver, ip) for ip in ips))
-    results = loop.run_until_complete(queue)
+    # TaskGroup is faster than gather in 3.14 and provides better error safety
+    async with asyncio.TaskGroup() as tg:
+        tasks = [tg.create_task(reverse_lookup(resolver, ip)) for ip in ips]
+
+    # After the 'async with' block, all tasks are guaranteed complete
+    results = [task.result() for task in tasks]
 
     # return dictionary instead of a list of dictionaries
     return {k: v for x in results for k, v in x.items()}

module/netbox/inventory.py

@@ -8,6 +8,7 @@
 #  repository or visit: <https://opensource.org/licenses/MIT>.
 
 import json
+import asyncio
 
 from module.netbox import *
 from module.common.misc import grab
@@ -428,7 +429,7 @@ def query_ptr_records_for_all_ips(self):
                 continue
 
             # get DNS names for IP addresses:
-            records = perform_ptr_lookups(data.get("ips"), data.get("servers"))
+            records = asyncio.run(perform_ptr_lookups(data.get("ips"), data.get("servers")))
 
             for ip in self.get_all_items(NBIPAddress):
 

pyproject.toml

@@ -10,12 +10,12 @@ license = "MIT"
 license-files = ["LICENSE.txt"]
 requires-python = ">=3.13"
 dependencies = [
-    "aiodns>=4.0.0",
+    "aiodns>=4.0.3",
     "hcloud>=2.20.0",
     "packaging>=26.2",
     "pyvmomi==9.1.0.0",
     "pyyaml>=6.0.3",
-    "requests>=2.34.1",
+    "requests>=2.34.2",
     "setuptools==82.0.1",
     "urllib3>=2.7.0",
     "wheel>=0.47.0",

requirements.txt

@@ -1,4 +1,4 @@
-aiodns==4.0.0
+aiodns==4.0.3
 certifi==2026.1.4
 cffi==2.0.0
 charset-normalizer==3.4.4
@@ -10,7 +10,7 @@ pycparser==3.0
 python-dateutil==2.9.0.post0
 pyvmomi==9.1.0.0
 pyyaml==6.0.3
-requests==2.34.1
+requests==2.34.2
 setuptools==82.0.1
 six==1.17.0
 urllib3==2.7.0