enforces custom attributes name constrains

refs: #186

Author: bb-Ricardo

module/sources/common/source_base.py

@@ -7,6 +7,8 @@
 #  For a copy, see file LICENSE.txt included in this
 #  repository or visit: <https://opensource.org/licenses/MIT>.
 
+import re
+
 from ipaddress import ip_interface, ip_address, IPv6Address, IPv4Address, IPv6Network, IPv4Network
 
 from module.netbox.inventory import (
@@ -630,6 +632,10 @@ def add_update_custom_field(self, data):
             new or updated NBCustomField
         """
 
+        # enforce NetBox name constrains
+        data["name"] = NetBoxObject.format_slug(
+            re.sub('-+', '-', data.get("name").replace("_", "-")).strip("-"), 100)[0:50].replace("-", "_")
+
         custom_field = self.inventory.get_by_data(NBCustomField, data={"name": data.get("name")})
 
         if custom_field is None:

module/sources/vmware/connection.py

@@ -824,17 +824,15 @@ def get_object_custom_fields(self, obj):
             if label is None:
                 continue
 
-            name = NetBoxObject.format_slug(f"vcsa_{label}", 50).replace("-", "_").strip("-_")
-
-            self.add_update_custom_field({
-                "name": name,
+            custom_field = self.add_update_custom_field({
+                "name": f"vcsa_{label}",
                 "label": label,
                 "content_types": [content_type],
                 "type": "text",
                 "description": f"vCenter '{self.name}' synced custom attribute '{label}'"
             })
 
-            return_custom_fields[name] = value
+            return_custom_fields[grab(custom_field, "data.name")] = value
 
         return return_custom_fields