Set primary ip setting

[rizlas]

Hi,
I'm testing the set_primary_ip setting to always. As I can see it is working fine but change logs view is populated with a lot of entries, but there is no difference in the object reported.

If setted to when_undefined no change logs are shown because indeed there are no difference between sync runs.

Is this an expected behavior? Setting to always I was expecting change log only when something inside the object change.

Thank you

[bb-Ricardo]

Do you have an example? I try to understand the issue. Which changeling do you mean? The one in NetBox itself or the netbox-sync log?

[bb-Ricardo]

Do you have a corresponding log entry? There should be one for updating the IP during the sync and then when writing to NetBox. The script also logs which attributes are written.

[rizlas]

Here some cut and paste logs 😄

2022-04-08 10:44:32,539 - DEBUG2: Trying to find prefix for IP: 192.168.9.9/24
2022-04-08 10:44:32,568 - DEBUG2: No matching NetBox prefix for '192.168.9.9/24' found
2022-04-08 10:44:32,615 - DEBUG2: Found existing NetBox IP address object: 192.168.9.9/24
2022-04-08 10:44:32,616 - DEBUG2: Parsing 'IP address' data structure: 192.168.9.9/24
2022-04-08 10:44:32,640 - DEBUG: Setting IP '192.168.9.9/24' as primary IPv4 for 'some_fqdn_machine'
2022-04-08 10:44:32,641 - DEBUG2: Parsing 'virtual machine' data structure: some_fqdn_machine
netbox-sync_1  | 2022-04-08 10:44:32,641 - INFO: Virtual machine 'some_fqdn_machine' attribute 'primary_ip4' changed from '{'id': 846, 'url': 'http://netbox:8080/api/ipam/ip-addresses/846/', 'display': '192.168.9.9/24', 'family': 4, 'address': '192.168.9.9/24'}' to '192.168.9.9/24'
2022-04-08 10:47:50,694 - INFO: Updating NetBox 'virtual machine' object 'some_fqdn_machine' with data: {'primary_ip4': 846}
2022-04-08 10:47:50,694 - DEBUG2: Sending PATCH to 'http://netbox:8080/api/virtualization/virtual-machines/22/' with data 'b'{"primary_ip4": 846}''.
2022-04-08 10:47:50,868 - DEBUG2: Received HTTP Status 200

[bb-Ricardo]

ok, yes, this should ne be happening. there is a validation missing to check if it's the same object (Thought I have taken care of this).

Would you mind opening an issue. Then I might be able to squeeze this in for 1.2.3

Thank you very much

[rizlas]

Sure thing, thank you as always.

[rizlas]

#172