Netbox 3.2 compatibility

[juliouzzzz]

Hi,

Did someone try the latest netbox-sync version (1.2.3) with netbox 3.2.1 ?

@bb-Ricardo : Are you working on a plugin compatibility version with changes of this major version ?

Thx
Julien

[bb-Ricardo]

Hi, I didn't test it with the latest NetBox version. But just started a basic test.

[juliouzzzz]

I've tested on our complexe environment and it works (netbox 3.2.2)

Just sync with vmware custom attributes have some errors (in our case, backup engine update vmware attribute, that it was sync by netbox-sync)

2022-05-06 08:04:14,236 - ERROR: NetBox returned: PATCH /api/virtualization/virtual-machines/396/ Bad Request
2022-05-06 08:04:14,236 - ERROR: NetBox returned body: {'__all__': ["Unknown field name 'vcsa_last-backup' in custom field data."]}
2022-05-06 08:04:14,237 - ERROR: Request Failed for virtual machine. Used data: {'custom_fields': {'vcsa_last-backup': '05/05/2022 19:04:58', 'vcsa_backup-status': 'Backup Job ID [909035]  Client: [VCENTER01], Backup Set: [defaultBackupSet], Subclient: [VM - INTRANET]'}}

i saw in netbox that custom fields have changed, and netbox-sync created new fields witch differences in usage of "-" and "_". And i think that's why he didn't find the field.

May i could delete custom field created by netbox-sync for vmware custom attributes ?
Will netbox-sync redo/rebuild custome_fields in netbox ?

Thanks

[bb-Ricardo]

Hi,

Can you please try the newest development branch? We fixed some issues regarding custom attributes.

[juliouzzzz]

Yes thanks, it works good.
I just need to delete the old custom_fields.
Maybe you can mention this on changelog, because if people had some custum_field in view list for example (like me) , we have to change that.
I saw that it has a changed because all my VM have -3days of last backup date :)

Thanks for you time, and continue this splendide work

[bb-Ricardo]

good point. #190

[bb-Ricardo]

can you describe what you exactly changed? would be easier for me then to add it to the changeling

[Wangjxg]

Hi,
I had used the netbox-sync version (1.2.3) with netbox 3.2.4 .
@bb-Ricardo After using the synchronization command, the log output is normal and no errors are reported. However, the data in the database is not synchronized.
How can this be solved?

2022-06-17 12:43:42,493 - INFO: Starting NetBox Sync v1.2.3 (2022-04-09)
2022-06-17 12:43:42,637 - INFO: Successfully connected to NetBox 'xxxx'
2022-06-17 12:43:42,638 - INFO: Initializing sources
2022-06-17 12:43:42,728 - INFO: Successfully connected to vCenter SDK 'xxxxx'
2022-06-17 12:43:42,972 - INFO: Successfully connected to vCenter API 'xxxxx'
...
2022-06-17 12:43:45,036 - INFO: Created new cluster type object: xxxx
2022-06-17 12:43:45,037 - INFO: Created new site object: vCenter: xxxx
2022-06-17 12:43:45,037 - INFO: Created new cluster object: xxxx

In setting.ini，there are multiple network segments (10.5.1.0/24, 10.5.2.0/24...). Can this be merged directly into 10.0.0.0/8?

# IP networks eligible to be synced to NetBox.
# permitted_subnets = 10.5.1.0/24, 10.5.2.0/24, 10.6.1.0/24
permitted_subnets = 10.0.0.0/8

Thx
Wang

[bb-Ricardo]

Hi,

I can't really answer the first question as there is the end of the log output missing.

On the second question: it depends! If all your internal IP addresses start with 10. and you want to sync them all, then yes 10.0.0.0/8 would be the correct expression.

[Wangjxg]

Sorry for not giving the full information. there is the end of the log output.

Traceback (most recent call last):
  File "./netbox-sync.py", line 145, in <module>
    main()
  File "./netbox-sync.py", line 127, in main
    inventory.query_ptr_records_for_all_ips()
  File "/opt/netbox-sync/module/netbox/inventory.py", line 354, in query_ptr_records_for_all_ips
    records = perform_ptr_lookups(data.get("ips"), data.get("servers"))
  File "/opt/netbox-sync/module/common/support.py", line 142, in perform_ptr_lookups
    results = loop.run_until_complete(queue)
  File "/usr/local/python3/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "/opt/netbox-sync/module/common/support.py", line 179, in reverse_lookup
    if all([bool(c.lower() in valid_hostname_characters) for c in response.name]):
  File "/opt/netbox-sync/module/common/support.py", line 179, in <listcomp>
    if all([bool(c.lower() in valid_hostname_characters) for c in response.name]):
AttributeError: 'int' object has no attribute 'lower'

In addition, I found it a bit strange to be able to synchronize successfully using this configuration in setting.ini

# IP networks eligible to be synced to NetBox.
# If an IP address is not part of this networks then it WON'T be synced to NetBox
permitted_subnets = 10.6.1.0/24, 10.6.2.0/24 

If you use 'permitted_subnets = 10.0.0.0/8', the synchronization will not be successful, and the previous log will be output

Thank you very much for your reply
Wang

[bb-Ricardo]

It's a bug in the script which I have to fix. You can just disable the dns lookup in the config for now and then it should work.

[Wangjxg]

ok,thanks

[bb-Ricardo]

the problem should be fixed in the current development branch