VM creation error Netbox v3.3.0

[yaiqsa]

Hey there,

I have some issues that I guess are caused by the Netbox v3.3.0 update:

When running netbox-sync on a new database, I get the following errors:

• First this one, about a site mismatch (I think the site field is just missing)

  2022-08-22 14:41:12,771 - INFO: Creating new NetBox 'virtual machine' object 'my-hostname' with data: {'tags': [{'name': 'NetBox-synced'}, {'name': 'Source: vcenter'}], 'name': 'my-hostname', 'cluster': 1,
   'status': 'active', 'memory': 8192, 'vcpus': 4, 'disk': 140, 'platform': 2, 'role': 2}
  2022-08-22 14:41:12,771 - DEBUG2: Sending POST to 'https://netbox.url/api/virtualization/virtual-machines/' with data 'b'{"tags": [{"name": "NetBox-synced"}, {"name": "Source: vcenter"
  }], "name": "my-hostname", "cluster": 1, "status": "active", "memory": 8192, "vcpus": 4, "disk": 140, "platform": 2, "role": 2}''.
  2022-08-22 14:41:12,804 - DEBUG2: Received HTTP Status 400.
  2022-08-22 14:41:12,804 - ERROR: NetBox returned: POST /api/virtualization/virtual-machines/ Bad Request
  2022-08-22 14:41:12,804 - ERROR: NetBox returned body: {'cluster': ['The selected cluster (my-cluster is not assigned to this site (None).']}
  2022-08-22 14:41:12,805 - ERROR: Request Failed for virtual machine. Used data: {'tags': [{'name': 'NetBox-synced'}, {'name': 'Source: vcenter'}], 'name': 'my-hostname', 'cluster': 1, 'status': 'active', 'memory': 8192, 'vcpus': 4, 'disk': 140, 'platform': 2, 'role': 2}
  2022-08-22 14:41:12,805 - DEBUG2: Adding unresolved dependencies back to object: ['primary_ip4']
  2022-08-22 14:41:12,805 - DEBUG2: Parsing 'virtual machine' data structure: my-hostname
  

• Then this one, which I think is caused by the VM not being created:

  2022-08-22 14:41:22,441 - INFO: Creating new NetBox 'virtual machine interface' object 'vNIC 1 (Network) (my-hostname)' with data: {'tags': [{'name': 'NetBox-synced'}, {'name': 'Source: vcenter'}], 'name': 'vNIC 1 (Network)', 'mac_address': '10:00:00:00:00:01', 'description': 'Network adapter 1 (VirtualE1000e) (vlan ID: 0)', 'enabled': True, 'mtu': 9000, 'mode': 'access'}
  2022-08-22 14:41:22,441 - DEBUG2: Sending POST to 'https://netbox.url/api/virtualization/interfaces/' with data 'b'{"tags": [{"name": "NetBox-synced"}, {"name": "Source: vcenter"}], "name": "vNIC 1 (Network)", "mac_address": "10:00:00:00:00:01", "description": "Network adapter 1 (VirtualE1000e) (vlan ID: 0)", "enabled": true, "mtu": 9000, "mode": "access"}''.
  2022-08-22 14:41:22,469 - DEBUG2: Received HTTP Status 400.
  2022-08-22 14:41:22,470 - ERROR: NetBox returned: POST /api/virtualization/interfaces/ Bad Request
  2022-08-22 14:41:22,470 - ERROR: NetBox returned body: {'virtual_machine': ['This field is required.']}
  2022-08-22 14:41:22,470 - ERROR: Request Failed for virtual machine interface. Used data: {'tags': [{'name': 'NetBox-synced'}, {'name': 'Source: vcenter'}], 'name': 'vNIC 1 (Network)', 'mac_address': '10:00:00:00:00:01', 'description': 'Network adapter 1 (VirtualE1000e) (vlan ID: 0)', 'enabled': True, 'mtu': 9000, 'mode': 'access'}
  2022-08-22 14:41:22,470 - DEBUG2: Adding unresolved dependencies back to object: ['virtual_machine']
  2022-08-22 14:41:22,471 - DEBUG2: Parsing 'virtual machine interface' data structure: vNIC 1 (Network) (my-hostname)
  

When I use my production database I get some more errors, but they might be caused by these objects not being created properly.

Am I correct that this is a netbox 3.3.0 compatibility issue, or is it just my environment? And if it is an incompatibility, when might this be resolved?

Thank you!

[Houtek]

There were a lo of api changes with 3.3.0 (https://github.com/netbox-community/netbox/releases/tag/v3.3.0), these might cause the issues in your environment.

[yaiqsa]

There were a lo of api changes with 3.3.0 (https://github.com/netbox-community/netbox/releases/tag/v3.3.0), these might cause the issues in your environment.

I noticed the api changes, that's why I was wondering if netbox-sync is outdated now. (as I said, I tested with an empty (new) database, so the chance it's just my enviroment seems small)

Does netbox-sync work for anyone else using Netbox 3.3.0?

[bb-Ricardo]

Hi, I will try to have a look today and see what needs to be changed.

NetBox keeps changing APIs all the time leaving all the tools in the dust.

[bb-Ricardo]

mmhm. As I use a minikube cluster with a helm chart as my test setup I rely on provided docker images. But currently there seems to be an issue in creating new docker images for version 3.3.0

netbox-community/netbox-docker#834

can someone perform a sync to 3.3.0 and send me the whole output (log level DEBUG2)? Because the API changes in 3.3.0 seem unrelated to the used attributes in netbox-sync

[t8simon]

So i got a similar issue on 3.2.7 on the development branch. But I'm not really sure if they are related or not.
The errors start like this:

2022-08-25 15:14:15,132 - INFO: Creating new NetBox 'cluster' object '<cluster name>' with data: {'tags': [{'name': 'NetBo
x-synced'}, {'name': 'Source: vcenter-<vcenter>'}, {'name': 'PRD'}], 'name': '<cluster name>', 'type': 3, 'group': 8, 'site': 1,
 'tenant': 1}
2022-08-25 15:14:15,132 - DEBUG2: Sending POST to '<netbox url>/api/virtualization/clusters/' with da
ta 'b'{"tags": [{"name": "NetBox-synced"}, {"name": "Source: vcenter-<vcenter>"}, {"name": "PRD"}], "name": "<cluster name>", "t
ype": 3, "group": 8, "site": 1, "tenant": 1}''.
2022-08-25 15:14:15,170 - DEBUG2: Received HTTP Status 400.
2022-08-25 15:14:15,170 - ERROR: NetBox returned: POST /api/virtualization/clusters/ Bad Request
2022-08-25 15:14:15,171 - ERROR: NetBox returned body: {'non_field_errors': ['The fields site, name must make a unique set.']}
2022-08-25 15:14:15,171 - ERROR: Request Failed for cluster. Used data: {'tags': [{'name': 'NetBox-synced'}, {'name': 'Source: vcenter-<vcenter>'}, {'name': 'PRD'}], 'name': '<cluster name>', 'type': 3, 'group': 8, 'site': 1, 'tenant': 1}

And here is the equivalent vm creation error - but it's not exactly the same:

2022-08-25 15:22:09,002 - DEBUG2: Parsing 'virtual machine' data structure: <vm name>
2022-08-25 15:22:09,002 - INFO: Creating new NetBox 'virtual machine' object '<vm name>' with data: {'tags': [{'name': 'NetBox-synced'}, {'name': 'Source: vcenter-<vcenter>'}], 'name': '<vm name>', 'status': 'active', 'memory': 8192, 'vcpus': 1, 'disk': 20, 'platform': 10, 'comments': 'OS: rhel7_64Guest', 'tenant': 5, 'role': 12, 'primary_ip4': 96}
2022-08-25 15:22:09,003 - DEBUG2: Sending POST to '<url>/api/virtualization/virtual-machines/' with data 'b'{"tags": [{"name": "NetBox-synced"}, {"name": "Source: vcenter-<cluster>"}], "name": "<vm name>", "status": "active", "memory": 8192, "vcpus": 1, "disk": 20, "platform": 10, "comments": "OS: rhel7_64Guest", "tenant": 5, "role": 12, "primary_ip4": 96}''.
2022-08-25 15:22:09,044 - DEBUG2: Received HTTP Status 400.
2022-08-25 15:22:09,044 - ERROR: NetBox returned: POST /api/virtualization/virtual-machines/ Bad Request
2022-08-25 15:22:09,044 - ERROR: NetBox returned body: {'cluster': ['This field is required.']}
2022-08-25 15:22:09,044 - ERROR: Request Failed for virtual machine. Used data: {'tags': [{'name': 'NetBox-synced'}, {'name': 'Source: vcenter-<cluster>'}], 'name': '<vm name>', 'status': 'active', 'memory': 8192, 'vcpus': 1, 'disk': 20, 'platform': 10, 'comments': 'OS: rhel7_64Guest', 'tenant': 5, 'role': 12, 'primary_ip4': 96}
2022-08-25 15:22:09,045 - DEBUG2: Adding unresolved dependencies back to object: ['cluster']

What I also found, is that the following part is missing during the VM data collection:
DEBUG2: Parsing 'cluster' data structure: <cluster name>

This is at the earlier "Parsing 'virtual machine' data structure" part. In development, this part is missing.

As a comparison, in the main branch the vm creation post looks like this:

2022-08-25 16:08:51,939 - INFO: Creating new NetBox 'virtual machine' object '<vm name>' with data: {'tags': [{'name': 'NetBox-synced'}, {'name': 'Source: vcenter-<vcenter>'}], 'name': '<vm name>', 'cluster': 7, 'status': 'active', 'memory': 8192, 'vcpus': 2, 'disk': 40, 'platform': 10, 'comments': 'OS: rhel7_64Guest', 'tenant': 19, 'role': 12}

So it seems in the development branch the cluster ID is not pushed during vm creation. Maybe this is because of the error before, where it wants to create clusters that already exists?

[bb-Ricardo]

I changed some code around the cluster creation. Somehow it doesn't seem to pick up the existing cluster and then everything goes to sh*t. Can you have a look at the updated config example file about the cluster site relation?

I added support for clusters with the same name but in different datacenters. And it could be caused by this change.

[t8simon]

So I have only unique cluster names, everything is defined like this: Cluster_NYC = New York.
But the clusters already do exist in netbox before the sync (which is no issue with main branch, but for the code on development it is).

[bb-Ricardo]

Then I will try to figure it out tonight.

[bb-Ricardo]

Hi @t8simon, I just tested it and it seems I at least found your issue. the script indeed tries to create a new cluster because the cluster group (Datacenter) is now part of the identifier to make this cluster unique. Lets how I can fix this.

[bb-Ricardo]

Hello @yaiqsa, @t8simon,

I just pushed a fix for the issue. Can you try latest development branch please and let me know if it's working? Preferably with 3.2 and 3.3 version if possible.

Thank you very much.