Skip to content

Video frames not advancing updates#399

Merged
ryanmccartney merged 18 commits into
masterfrom
update-video-frames-not-advancing
Aug 20, 2025
Merged

Video frames not advancing updates#399
ryanmccartney merged 18 commits into
masterfrom
update-video-frames-not-advancing

Conversation

@ryanmccartney

@ryanmccartney ryanmccartney commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

📺 What

Update the videoFramesNotAdvancing implementation to handle additional invalid or inaccurate values being reported by the Video Quality API.

🛠 How

Deals with 3 observed cases:

  • Increases the default thresholdInSeconds to 5. As many WebKit-based TV environment only appear to provide an update to this value every ~2-seconds
  • Handle cases where some devices always report the maximum value of 32-bit signed integer as their totalVideoFrames value on the Video Quality API when playing a live stream. Caused by some implementations using totalVideoFrames = mediaTime * frameRate
  • Finally, only trigger when frames are explicitly not changing, i.e previousFrames !== currentFrames. Some devices appear to reset totalVideoFrames to 0 if the decoder is reinitialised.

@ryanmccartney ryanmccartney requested a review from a team as a code owner August 18, 2025 11:43
@ryanmccartney ryanmccartney added the semver patch This PR is a semver patch release label Aug 19, 2025
@ryanmccartney ryanmccartney merged commit be3b480 into master Aug 20, 2025
4 checks passed
@ryanmccartney ryanmccartney deleted the update-video-frames-not-advancing branch August 20, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver patch This PR is a semver patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants