Merge pull request #14124 from bbc/missing-page-view-change

Move pageview tracking to OptimizelyProvider

Author: LilyL0u

src/app/components/OptimizelyPageMetrics/PageViewTracking/index.test.tsx

@@ -19,10 +19,10 @@ The `OptimizelyPageMetric` component:
 
 | Name              | type    | default | Description                         |
 | ----------------- | ------- | ------- | ----------------------------------- |
-| trackPageView     | boolean | false   | Enables tracking of page views.     |
 | trackPageDepth    | boolean | false   | Enables tracking of scroll depth.   |
 | trackPageComplete | boolean | false   | Enables tracking of page completes. |
-| trackVisit        | boolean | false   | Enables tracking of visits.         |
+
+> Page view (`page-views`) and visit (`visit`) events are not controlled by this component. They are tracked from the Optimizely `DECISION` notification listener in [`withOptimizelyProvider`](../../legacy/containers/PageHandlers/withOptimizelyProvider/index.tsx). See [Page views per visit ratio metric](#page-views-per-visit-ratio-metric) below.
 
 ## experimentsForPageMetrics Array
 
@@ -61,7 +61,7 @@ You can use once on a page
 
 ```tsx
 {
-  <OptimizelyPageMetrics trackPageComplete trackPageView trackPageDepth />;
+  <OptimizelyPageMetrics trackPageComplete trackPageDepth />;
 }
 ```
 
@@ -74,9 +74,9 @@ Or multiple times to invoke different page metrics in different sections of the
     <OptimizelyPageMetrics trackPageComplete />
   </main>;
   {
-    /* Track page views & scroll depth outside the main section of the page */
+    /* Track scroll depth outside the main section of the page */
   }
-  <OptimizelyPageMetrics trackPageView trackPageDepth />;
+  <OptimizelyPageMetrics trackPageDepth />;
 }
 ```
 
@@ -87,10 +87,8 @@ The page views per visit ratio metric is built from two Optimizely events:
 - numerator: `page-views`
 - denominator: `visit`
 
-Visit counting is session based. A new visit is counted when there has been at least 30 minutes of inactivity since the last tracked page view. Each tracked page view updates the last activity timestamp so that continued browsing keeps the same visit.
-
-When `trackPageView` and `trackVisit` are both enabled, the visit event is sent before the page view event on the same page load. This ensures the ratio metric counts the page view within Optimizely's 48 hour attribution window for the denominator.
+Both events are tracked from the `DECISION` notification listener in [`withOptimizelyProvider`](../../legacy/containers/PageHandlers/withOptimizelyProvider/index.tsx), not from this component. Tracking them from the listener ensures the visit (denominator) is always sent before the page view (numerator) on the same page load, so the page view falls inside Optimizely's 48 hour attribution window for the denominator. Tracking from the listener also guarantees the events fire for every activated experiment, independent of this component's render lifecycle.
 
-For page views per visit, enable both `trackPageView` and `trackVisit`. Visit events are emitted from the page view tracker to preserve ordering and avoid duplicate visits.
+Events are de-duplicated per navigation: while the current URL (pathname + query string) is unchanged, multiple `DECISION` notifications will only emit `page-views` (and `visit`) once; navigating to a different URL and later returning may emit `page-views` again, and `visit` will only emit when the 30-minute inactivity window has elapsed.
 
 For interpretation, add the numerator and denominator events as separate metrics alongside the ratio metric in Optimizely.

src/app/components/OptimizelyPageMetrics/PageViewTracking/index.tsx

@@ -11,11 +11,11 @@ type ExperimentsForPageTypeMetrics = {
 const experimentsForPageMetrics: ExperimentsForPageTypeMetrics = [
   {
     pageType: ARTICLE_PAGE,
-    activeExperiments: ['newswb_ws_topic_discovery_module'],
+    activeExperiments: ['test_page_views_aa_3'],
   },
   {
     pageType: MEDIA_ARTICLE_PAGE,
-    activeExperiments: ['newswb_ws_topic_discovery_module'],
+    activeExperiments: ['test_page_views_aa_3'],
   },
 ];