WS-2638 - MAP Promo Playback on Homepage and Topics [SPIKE]#14087
WS-2638 - MAP Promo Playback on Homepage and Topics [SPIKE]#14087pvaliani wants to merge 8 commits into
Conversation
| promo, | ||
| promoIndex, | ||
| mediaBlocks, | ||
| }: Props): InSituPlaybackEligibility => { |
There was a problem hiding this comment.
So is this a blanket rule for every hieirachicalGrid view the first promo will show as in-situ playback.
It's not just if its the first curation on the page?
(would be uncomfortable with the latter as it starts to make the rendering very unpredictable)
There was a problem hiding this comment.
Yeah no worries. The intention is that the first promo in every Hierarchical Grid can support in-situ playback when eligible, rather than only the first curation on the page. We can make this clearer in the implementation
| const inSituPlaybackEligibility = getInSituPlaybackEligibility({ | ||
| promo, | ||
| promoIndex: i, | ||
| mediaBlocks: promo.inSituMedia, | ||
| }); | ||
| const eligibleInSituMediaBlocks = | ||
| !isAmp && inSituPlaybackEligibility.isEligible | ||
| ? inSituPlaybackEligibility.mediaBlocks | ||
| : null; | ||
| const inSituMediaBlocks = eligibleInSituMediaBlocks; |
There was a problem hiding this comment.
From a maintainability standpoint this logic definitely belongs in the BFF as it is pure business logic
There was a problem hiding this comment.
Agreed. Based on Option B from the spike we can move the eligibility checks into the BFF so Simorgh does not decide whether a promo qualifies. Simorgh would only render the in-situ player when the BFF provides the required media data. This was linked to performance concerns in Option A
| VISUAL_PROMINENCE, | ||
| VISUAL_STYLE, | ||
| } from '#app/models/types/curationData'; | ||
| import getPageData from '../pageRequests/getPageData'; |
There was a problem hiding this comment.
I think there is a lot of logic that belongs in the BFF in this file, I'd try and only send to the frontend what is need to render nothing more
|
Thanks for the spike feedback @andrewscfc! |
2 participants
Resolves JIRA:
https://bbc.atlassian.net/browse/WS-2638
Summary
Screen.Recording.2026-06-03.at.15.40.05.mov
EDIT:
Also checked on Home page (arabic):
Code changes
Testing
Test link: http://localhost.bbc.com:7081/arabic/topics/cz9mm6r1q5et?renderer_env=live
Useful Links