WS-2501 - Prepare topic discovery for rollout#14165
Merged
Merged
Conversation
…o prepare-topic-discovery-for-rollout
…o prepare-topic-discovery-for-rollout
Base automatically changed from
WS-2854-translations-for-topic-discovery-component
to
latest
June 30, 2026 13:13
louisearchibald
approved these changes
Jul 1, 2026
andrewscfc
reviewed
Jul 2, 2026
andrewscfc
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
TopicDiscoverycomponent with improved support for right-to-left (RTL) languages, adds arabic story to storybook so it can be tested. It introduces new test fixtures and Storybook stories for Arabic topics, ensures correct RTL rendering, and removes unused experiment-related code for both click and view tracking. The changes also include minor styling and prop cleanup.RTL and Arabic Support Enhancements:
fixtures.ts, enabling comprehensive testing and story coverage for RTL languages.index.stories.tsx) to include scenarios for Arabic topics and RTL rendering, using new fixtures and a fetch mock decorator.index.test.tsxto verify correct RTL rendering, topic switching, and text direction for Arabic topics. [1] [2]Component and Prop Simplification:
experimentPropsfromTopicDiscoveryand related components, cleaning up the props and internal logic. [1] [2] [3] [4] [5] [6]dirattribute is set on the main section element based on the current service's direction (LTR or RTL), improving accessibility and layout for RTL languages.Event Tracking Cleanup:
useClickTrackerHandler) and view (useViewTracker) hooks, as these experiments are no longer active. [1] [2] [3] [4]Styling Adjustments:
moreAboutLinkstyle by removing unnecessary padding, making the styling more consistent.Miscellaneous:
ArticlePage.tsx, including the removal of experiment-related context and props. [1] [2] [3]Also adds the topic discovery component to the media article page with the same toggle and same conditional logic.
I sent @eagerterrier a file to upload to enable the toggles on test, as the interface is currently not working properly.
Some screenshots:
Summary
A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.
Code changes
Testing
Useful Links