fix: Coderabbit review comments

Author: PeterC89

packages/webui/src/client/lib/Escape.tsx

@@ -54,7 +54,6 @@ function usePortal(id: string, style?: Partial<Record<keyof React.CSSProperties,
 
 			return function removeElement() {
 				rootElemRef.current?.remove()
-				rootElemRef.current = null
 				if (parentCreatedByThisHook && !parentElem.childElementCount) {
 					parentElem.remove()
 				}
@@ -63,6 +62,13 @@ function usePortal(id: string, style?: Partial<Record<keyof React.CSSProperties,
 		[id]
 	)
 
+	useEffect(function cleanupOnUnmount() {
+		return function removeOnUnmount() {
+			rootElemRef.current?.remove()
+			rootElemRef.current = null
+		}
+	}, [])
+
 	/**
 	 * It's important we evaluate this lazily:
 	 * - We need first render to contain the DOM element, so it shouldn't happen

packages/webui/src/client/lib/viewPort.ts

@@ -50,14 +50,11 @@ export function maintainFocusOnPartInstance(
 	noAnimation?: boolean
 ): void {
 	focusState.startTime = Date.now()
-	viewPortScrollingState.isProgrammaticScrollInProgress = true
-	viewPortScrollingState.lastProgrammaticScrollTime = Date.now()
 
 	const focus = async () => {
 		// Only proceed if we're not already scrolling and within the time window
 		if (!focusState.isScrolling && Date.now() - focusState.startTime < timeWindow) {
 			focusState.isScrolling = true
-			viewPortScrollingState.lastProgrammaticScrollTime = Date.now()
 
 			try {
 				await scrollToPartInstance(partInstanceId, forceScroll, noAnimation)

packages/webui/src/client/ui/SegmentTimeline/Renderers/VTSourceRenderer.tsx

@@ -216,8 +216,16 @@ class VTSourceRendererBase extends CustomLayerItemRenderer<IProps & WithTranslat
 	}
 
 	private hasStateChanges = (newState: Partial<IState>): boolean => {
-		for (const [key, value] of Object.entries(newState)) {
-			if (this.state[key as keyof IState] !== value) {
+		const keys: Array<keyof IState> = [
+			'rightLabelIsAppendage',
+			'noticeLevel',
+			'begin',
+			'end',
+			'sourceEndCountdownAppendage',
+		]
+
+		for (const key of keys) {
+			if (Object.prototype.hasOwnProperty.call(newState, key) && this.state[key] !== newState[key]) {
 				return true
 			}
 		}