Skip to content

Commit 5f37a3a

Browse files
committed
Remove broken PreviewPopUp css hidden feature
The CSS was wrong and it wasn't used. We unmount the component when we don't want to see it, which is probably a much better choice for this component.
1 parent 0cc0574 commit 5f37a3a

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

packages/webui/src/client/ui/PreviewPopUp/PreviewPopUp.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@
4343
width: 322px;
4444
--preview-max-dimension: 320;
4545
}
46-
47-
&--hidden {
48-
visibility: none;
49-
}
5046
}
5147

5248
.preview-popUp__preview {

packages/webui/src/client/ui/PreviewPopUp/PreviewPopUp.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,12 @@ export const PreviewPopUp = React.forwardRef<
1212
padding: Padding
1313
placement: Placement
1414
size: 'small' | 'large'
15-
hidden?: boolean
1615
preview?: React.ReactNode
1716
initialOffsetX?: number
1817
trackMouse?: boolean
1918
}>
2019
>(function PreviewPopUp(
21-
{ anchor, padding, placement, hidden, size, children, initialOffsetX, trackMouse },
20+
{ anchor, padding, placement, size, children, initialOffsetX, trackMouse },
2221
ref
2322
): React.JSX.Element {
2423
const [popperEl, setPopperEl] = useState<HTMLDivElement | null>(null)
@@ -110,7 +109,6 @@ export const PreviewPopUp = React.forwardRef<
110109
className={classNames('preview-popUp', {
111110
'preview-popUp--large': size === 'large',
112111
'preview-popUp--small': size === 'small',
113-
'preview-popUp--hidden': hidden,
114112
})}
115113
style={styles.popper}
116114
{...attributes.popper}

0 commit comments

Comments
 (0)