Merge pull request #28 from abeaumont/feature/error-reporting

native: Improve error reporting

Author: smola

native/src/main/java/bblfsh/Driver.java

@@ -1,9 +1,15 @@
 package bblfsh;
 
+import org.eclipse.jdt.core.dom.Message;
+
 import sun.reflect.annotation.ExceptionProxy;
 
 import java.io.IOException;
+
 import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.stream.Stream;
+import java.util.stream.Collectors;
 
 public class Driver {
 
@@ -63,8 +69,10 @@ private Response processRequest(final Request request) {
         } catch (IOException e) {
             return createFatalResponse(e);
         }
-
-        response.status = "ok";
+        response.errors = Arrays.stream(response.ast.getMessages())
+            .map(Message::getMessage)
+            .collect(Collectors.toCollection(ArrayList::new));
+        response.status = response.errors.isEmpty() ? "ok" : "error";
         return response;
     }
 }

native/src/test/java/bblfsh/DriverTest.java

@@ -40,6 +40,20 @@ public void exitOnCloseIn() throws DriverException, CloseException {
         } catch (CloseException ex) { }
     }
 
+    @Test
+    public void processError() throws DriverException, CloseException {
+        final String input = "{\"content\":\"package\"}\n";
+        final InputStream in = new ByteArrayInputStream(input.getBytes());
+        final RequestReader reader = new RequestReader(in);
+
+        final ByteArrayOutputStream out = new ByteArrayOutputStream();
+        final ResponseWriter writer = new ResponseWriter(out);
+
+        final Driver driver = new Driver(reader, writer);
+        driver.processOne();
+        assertThat(out.toString()).contains("\"status\":\"error\"");
+    }
+
     @Test
     public void processInvalid() throws DriverException, CloseException {
         final String input = "garbage";