Skip to content

refactor(python): merge safe_codec into tywrap_bridge_core#298

Merged
bbopen merged 1 commit into
mainfrom
refactor/0.9-safe-codec-merge
Jul 11, 2026
Merged

refactor(python): merge safe_codec into tywrap_bridge_core#298
bbopen merged 1 commit into
mainfrom
refactor/0.9-safe-codec-merge

Conversation

@bbopen

@bbopen bbopen commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • Move the Python BridgeCodec, CodecError, and convenience encode/decode
    functions into runtime/tywrap_bridge_core.py.
  • Delete runtime/safe_codec.py and update direct imports.
  • Keep the existing python_bridge.py compatibility re-exports.
  • Regenerate the embedded Pyodide bridge core.

What broke and why it cannot now

The subprocess and Pyodide paths previously split Python codec behavior across
safe_codec.py and bridge-core equivalents. Codec value handling and payload
limits now come from one implementation, so the two runtimes cannot drift when
new Python value types or validation rules are added.

BREAKING CHANGE

Direct imports from the internal runtime.safe_codec module must change to
runtime.tywrap_bridge_core. Public names remain available from bridge core,
and python_bridge.py retains its existing compatibility exports.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@bbopen, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ed4e5a73-0426-4a9b-8f80-506217718712

📥 Commits

Reviewing files that changed from the base of the PR and between 0a03aaa and bebe8d8.

📒 Files selected for processing (5)
  • runtime/python_bridge.py
  • runtime/safe_codec.py
  • runtime/tywrap_bridge_core.py
  • src/runtime/pyodide-bootstrap-core.generated.ts
  • test/python/test_bridge_codec.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/0.9-safe-codec-merge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bbopen bbopen force-pushed the refactor/0.9-safe-codec-merge branch from dd71871 to bebe8d8 Compare July 11, 2026 21:05
@bbopen bbopen merged commit 344c9d7 into main Jul 11, 2026
23 checks passed
@bbopen bbopen deleted the refactor/0.9-safe-codec-merge branch July 11, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant