Solved IntelliJ warnings

Author: bbottema

src/main/java/org/bbottema/javareflection/BeanUtils.java

@@ -116,8 +116,9 @@ public static boolean isBeanMethod(final Method method, final Class<?> boundaryM
 	/**
 	 * @return Same as {@link #isBeanMethod(Method, Class, EnumSet)}, but may consider methods declared on interfaces as well.
 	 */
+	@SuppressWarnings("WeakerAccess")
 	public static boolean isBeanMethod(Method method, Class<?> boundaryMarker,
-										EnumSet<Visibility> visibility, boolean checkBeanLikeForInterfaces) {
+									   EnumSet<Visibility> visibility, boolean checkBeanLikeForInterfaces) {
 		return method.getDeclaringClass().isInterface()
 				? checkBeanLikeForInterfaces && methodIsBeanlike(method)
 				: isBeanMethodForField(method, boundaryMarker, visibility);

src/main/java/org/bbottema/javareflection/LookupCaches.java

@@ -7,7 +7,6 @@
 import org.jetbrains.annotations.Nullable;
 
 import java.lang.reflect.Method;
-import java.util.EnumSet;
 import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.List;
@@ -33,16 +32,16 @@ public class LookupCaches {
 	 * combinations using autoboxing and/or automatic common conversions can become very large (7000+ with only three parameters) and can become a
 	 * real problem. The more frequently a method is being called the larger the performance gain, especially for methods with long parameter lists
 	 *
-	 * @see MethodUtils#addMethodToCache(Class, String, Set, Class[])
-	 * @see MethodUtils#getMethodFromCache(Class, String, Class[])
+	 * @see "MethodUtils.addMethodToCache(Class, String, Set, Class[])"
+	 * @see "MethodUtils#getMethodFromCache(Class, String, Class[])"
 	 */
 	final static Map<Class<?>, Map<String, Map<Class<?>[], Set<InvokableObject>>>> METHOD_CACHE = new LinkedHashMap<>();
 
 	static final Map<Class<?>, Set<Class<?>>> CACHED_REGISTERED_COMPATIBLE_TARGET_TYPES = new HashMap<>();
 	static final Map<Class<?>, Set<Class<?>>> CACHED_COMPATIBLE_TARGET_TYPES = new HashMap<>();
-	static final Map<Set<LookupMode>, Map<ArrayKey, List<Class<?>[]>>> CACHED_COMPATIBLE_TYPE_LISTS = new HashMap<>();
+	private static final Map<Set<LookupMode>, Map<ArrayKey, List<Class<?>[]>>> CACHED_COMPATIBLE_TYPE_LISTS = new HashMap<>();
 
-	@SuppressWarnings({"WeakerAccess", "unused"})
+	@SuppressWarnings({"unused"})
 	public static void resetCache() {
 		CLASS_CACHE.clear();
 		METHOD_CACHE.clear();
@@ -55,10 +54,7 @@ public static void resetCache() {
 	static List<Class<?>[]> getCachedCompatibleSignatures(Set<LookupMode> lookupMode, ArrayKey arrayKey) {
 		final Map<ArrayKey, List<Class<?>[]>> cachedCompatibleSignatures = CACHED_COMPATIBLE_TYPE_LISTS.get(lookupMode);
 		if (cachedCompatibleSignatures != null) {
-			final List<Class<?>[]> cachedResult = cachedCompatibleSignatures.get(arrayKey);
-			if (cachedResult != null) {
-				return cachedResult;
-			}
+			return cachedCompatibleSignatures.get(arrayKey);
 		}
 		return null;
 	}

src/main/java/org/bbottema/javareflection/PackageUtils.java

@@ -3,6 +3,7 @@
 import lombok.experimental.UtilityClass;
 import org.jetbrains.annotations.Nullable;
 
+@SuppressWarnings("WeakerAccess")
 @UtilityClass
 public final class PackageUtils {
 

src/main/java/org/bbottema/javareflection/ReflectionUtils.java

@@ -12,7 +12,7 @@
 public class ReflectionUtils {
 
 	@SuppressWarnings("FieldCanBeLocal")
-	private static String INVALID_GENERIC_TYPE_DEFINITION = "Unable to determine generic type, probably due to type erasure. Make sure the type is part of a class signature (it can not be a field or variable, or a nested generic type such as List<NestedType>)";
+	private static final String INVALID_GENERIC_TYPE_DEFINITION = "Unable to determine generic type, probably due to type erasure. Make sure the type is part of a class signature (it can not be a field or variable, or a nested generic type such as List<NestedType>)";
 
 	/**
 	 * Inspects a inheritance chain of classes until the <em>classOfInterest</em> is found and then will look for the Generic type declared for the given (zero-based) index.

src/main/java/org/bbottema/javareflection/util/ExternalClassLoader.java

@@ -168,7 +168,7 @@ private Class<?> loadClass(final String classPath, final String className)
 		// get data from file
 		final File f = new File(classPath);
 		final int size = (int) f.length();
-		final byte buff[] = new byte[size];
+		final byte[] buff = new byte[size];
 		final DataInputStream dis = new DataInputStream(new FileInputStream(f));
 		dis.readFully(buff);
 		dis.close();

src/main/java/org/bbottema/javareflection/util/commonslang25/NumberUtils.java

@@ -54,7 +54,6 @@ public static boolean isNumber(String str) {
 		int i = start;
 		// loop to the next to last char or to the last char if we need another digit to
 		// make a valid number (e.g. chars[0..5] = "1234E")
-		//noinspection ConstantConditions
 		while (i < sz || (i < sz + 1 && allowSigns && !foundDigit)) {
 			if (chars[i] >= '0' && chars[i] <= '9') {
 				foundDigit = true;

src/main/java/org/bbottema/javareflection/util/commonslang25/StringUtils.java

@@ -30,6 +30,6 @@ public static String capitalize(String str) {
 		if (str == null || str.length() == 0) {
 			return str;
 		}
-		return String.valueOf(Character.toTitleCase(str.charAt(0))) + str.substring(1);
+		return Character.toTitleCase(str.charAt(0)) + str.substring(1);
 	}
 }