--output-dir fails if any cdylib exists in the workspace without a .so file

[notdanilo]

These lines makes it fail if we have another cdylib crate without a .so file.

cargo-ndk/src/cli/mod.rs

Lines 743 to 753 in 87b29ee

	for artifact in artifacts.iter().filter(|a| artifact_is_cdylib(a)) {
	let Some(file) = artifact
	.filenames
	.iter()
	.find(|name| name.extension() == Some("so"))
	else {
	// This should never happen because we filter for cdylib outputs above but you
	// never know... and it still feels better than just unwrapping
	shell.error("No cdylib file found to copy")?;
	std::process::exit(1);
	};

It adds two problems:

1. cargo ndk fails if the host is windows & another cdylib crate exists compiled to .dll
2. cargo ndk will incorrectly copy .so files if host is linux & another cdylib crate exists with .so compiled to a non-android platform

I could fix this, but I don't know what would be the ideal way to do it without adding a breaking change.

[bbqsrc]

Breaking changes are acceptable if there's no other sane way to fix it.

[StantonMatt]

This looks fixed on current main by 9672f44 (Only copy .so from the current crate).

The output-copying path now determines the selected package from the manifest and filters cdylib artifacts with:

.filter(|a| a.package_id == current_package_id)

before requiring a .so filename. That should address both cases from the issue: a sibling workspace cdylib without a .so no longer trips the copy loop, and a non-Android .so from another package should not be copied into the requested target output directory.

I did not find a regression test attached to that commit, but the current code path matches the intended fix. This issue can probably be closed unless someone still has a reproducer against main.