Merge pull request #16 from bbrowning/narrow-github-pat

Narrow GitHub PAT injection to api.github.com only

Author: bbrowning

CLAUDE.md

@@ -93,8 +93,7 @@ The default credential routing is defined in `internal/credentials/credentials.j
 | `*.anthropic.com` | `x-api-key: <key>` | `ANTHROPIC_API_KEY` |
 | `*.openai.com` | `Authorization: Bearer <key>` | `OPENAI_API_KEY` |
 | `*.cursor.com`, `*.cursorapi.com` | `Authorization: Bearer <key>` | `CURSOR_API_KEY` |
-| `github.com`, `api.github.com` | `Authorization: Bearer <pat>` | `GH_TOKEN` |
-| `*.githubusercontent.com` | `Authorization: Bearer <pat>` | `GH_TOKEN` |
+| `api.github.com` | `Authorization: Bearer <pat>` | `GH_TOKEN` |
 | `*.googleapis.com` | `Authorization: Bearer <token>` | gcloud ADC (auto-refresh) |
 
 ## Client Compatibility

internal/credentials/config_test.go

@@ -232,35 +232,40 @@ func TestBuildFromConfig_GitHubBearer(t *testing.T) {
 			{
 				EnvVar:       "TEST_GH_TOKEN",
 				InjectorType: "bearer",
-				Domains:      []string{"github.com", "api.github.com", ".githubusercontent.com"},
+				Domains:      []string{"api.github.com"},
 			},
 		},
 	}
 
 	store, _, _ := BuildFromConfig(cfg)
 
-	// Test exact domain match
 	req := &http.Request{
-		URL:    &url.URL{Host: "github.com"},
+		URL:    &url.URL{Host: "api.github.com"},
 		Header: make(http.Header),
 	}
 	if matched, injected := store.InjectCredentials(req); !matched || !injected {
-		t.Error("should match github.com")
+		t.Error("should match api.github.com")
 	}
 	if got := req.Header.Get("Authorization"); got != "Bearer ghp_test" {
 		t.Errorf("Authorization = %q, want %q", got, "Bearer ghp_test")
 	}
 
-	// Test suffix domain match
+	// github.com should NOT match (no PAT for git clone of public repos)
 	req2 := &http.Request{
-		URL:    &url.URL{Host: "raw.githubusercontent.com"},
+		URL:    &url.URL{Host: "github.com"},
 		Header: make(http.Header),
 	}
-	if matched, injected := store.InjectCredentials(req2); !matched || !injected {
-		t.Error("should match raw.githubusercontent.com")
+	if matched, _ := store.InjectCredentials(req2); matched {
+		t.Error("should not match github.com")
 	}
-	if got := req2.Header.Get("Authorization"); got != "Bearer ghp_test" {
-		t.Errorf("Authorization = %q, want %q", got, "Bearer ghp_test")
+
+	// raw.githubusercontent.com should NOT match
+	req3 := &http.Request{
+		URL:    &url.URL{Host: "raw.githubusercontent.com"},
+		Header: make(http.Header),
+	}
+	if matched, _ := store.InjectCredentials(req3); matched {
+		t.Error("should not match raw.githubusercontent.com")
 	}
 }
 

internal/credentials/credentials.json

@@ -21,7 +21,7 @@
     {
       "env_var": "GH_TOKEN",
       "injector": "bearer",
-      "domains": ["github.com", "api.github.com", ".githubusercontent.com"]
+      "domains": ["api.github.com"]
     },
     {
       "env_var": "GOOGLE_APPLICATION_CREDENTIALS",