Fix nil req.URL crash for gRPC/HTTP2 requests in MITM mode#18
Merged
Conversation
When gRPC clients (like dolt's eventsapi) connect through the MITM proxy, they use HTTP/2 which doesn't have a traditional request-line. Instead, HTTP/2 uses pseudo-headers (:method, :path, :authority, :scheme). goproxy was designed for HTTP/1.1 and doesn't properly reconstruct req.URL from HTTP/2 pseudo-headers in MITM mode, leaving it nil. This caused the proxy to crash when accessing req.URL.Host. This fix: - Detects when req.URL is nil - Logs diagnostic information (Method, Host, RequestURI, Proto) - Reconstructs req.URL from req.Host and req.RequestURI when available - Only returns an error if reconstruction is impossible This allows gRPC traffic (eventsapi.dolthub.com) to flow through the proxy while still catching genuinely malformed requests. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When gRPC clients (like dolt's eventsapi) connect through the MITM proxy, they use HTTP/2 which doesn't have a traditional request-line. Instead, HTTP/2 uses pseudo-headers (:method, :path, :authority, :scheme).
goproxy was designed for HTTP/1.1 and doesn't properly reconstruct req.URL from HTTP/2 pseudo-headers in MITM mode, leaving it nil. This caused the proxy to crash when accessing req.URL.Host.
This fix:
This allows gRPC traffic (eventsapi.dolthub.com) to flow through the proxy while still catching genuinely malformed requests.