Test exceptions from loading via entry_points

Author: abkfenris

tests/test_config.py

@@ -4,11 +4,17 @@
 
 from typing import Any
 from unittest import TestCase
+from unittest.mock import Mock, patch
 
 import pytest
 import xarray as xr
 
-from xrlint.config import Config, ConfigObject, get_entry_point_plugins
+from xrlint.config import (
+    Config,
+    ConfigObject,
+    get_entry_point_plugins,
+    plugins_from_entry_points,
+)
 from xrlint.constants import CORE_PLUGIN_NAME
 from xrlint.plugin import Plugin, new_plugin
 from xrlint.processor import ProcessorOp, define_processor
@@ -50,6 +56,43 @@ def test_get_rule(self):
         with pytest.raises(ValueError, match="unknown rule 'foo'"):
             config_obj.get_rule("foo")
 
+    def test_plugins_from_entry_points_load_failure(self):
+        """Test that plugins_from_entry_points raises ValueError when entry point fails to load."""
+        # Create a mock entry point that raises an exception when loaded
+        mock_entry_point = Mock()
+        mock_entry_point.name = "failing-plugin"
+        mock_entry_point.load.side_effect = ImportError("Module not found")
+
+        # Mock the entry_points function to return our failing entry point
+        with patch("importlib.metadata.entry_points") as mock_entry_points:
+            mock_entry_points.return_value = [mock_entry_point]
+
+            # Verify it raises the expected ValueError with the proper message
+            with pytest.raises(
+                ValueError,
+                match=r"failed to load xrlint plugin from entry point 'failing-plugin'",
+            ):
+                plugins_from_entry_points()
+
+    def test_plugins_from_entry_points_export_failure(self):
+        """Test when the plugin module loads but export_plugin() fails."""
+        # Create a mock module that loads successfully but export_plugin() fails
+        mock_module = Mock()
+        mock_module.export_plugin.side_effect = AttributeError("missing attribute")
+
+        mock_entry_point = Mock()
+        mock_entry_point.name = "bad-export-plugin"
+        mock_entry_point.load.return_value = mock_module
+
+        with patch("importlib.metadata.entry_points") as mock_entry_points:
+            mock_entry_points.return_value = [mock_entry_point]
+
+            with pytest.raises(
+                ValueError,
+                match=r"failed to load xrlint plugin from entry point 'bad-export-plugin'",
+            ):
+                plugins_from_entry_points()
+
     def test_get_processor_op(self):
         class MyProc(ProcessorOp):
             def preprocess(

xrlint/config.py

@@ -44,13 +44,6 @@
 """
 
 
-def get_core_plugin() -> "Plugin":
-    """Get the fully imported, populated core plugin."""
-    from xrlint.plugins.core import export_plugin
-
-    return export_plugin()
-
-
 def plugins_from_entry_points() -> dict[str, "Plugin"]:
     """Load plugins from entry points.
 
@@ -67,7 +60,6 @@ def plugins_from_entry_points() -> dict[str, "Plugin"]:
             plugin = plugin_module.export_plugin()
             plugins[plugin.meta.name] = plugin
         except Exception as e:
-            breakpoint()
             raise ValueError(
                 f"failed to load xrlint plugin from entry point {ep.name!r}: {e}"
             ) from e