Jasper 736 - show notification popup when order received while user logged in.#1042
Draft
devinleighsmith wants to merge 14 commits into
Draft
Jasper 736 - show notification popup when order received while user logged in.#1042devinleighsmith wants to merge 14 commits into
devinleighsmith wants to merge 14 commits into
Conversation
feat: display two new types on ui feat: tooltip for new types in table
1) handlers are not responsible for determining if they should be executed or not. 2) handlers are extracted out into their own files.
|
Contributor
|
Not a big deal but looks like there are some code from Josh's PR (#1026) and could be resolved by rebasing this branch from master. |
|
|
||
| snackbarStore.showSnackbar( | ||
| buildOrderReceivedMessage(order), | ||
| '#b4e6ff', |
Contributor
There was a problem hiding this comment.
nit: is it possible to put this hex color in color.css just for consistency?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: on hold until JASPER 730 is merged - this PR is dependent.
Pull Request for JIRA Ticket: ----JASPER-376----
Issue ticket number and link
JASPER-376
Description
Display a snackbar message when an order notification is received (via websocket). This message provides a link to the order for convenience.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested by sending an artificial order via postman to pcsstest user, and validating that the vue frontend displayed a message.
Checklist: