Jasper 818 - fix duplication of documents in judicial binders#1043
Merged
Conversation
…ore adding to binder.
|
WadeBarnes
approved these changes
May 8, 2026
devinleighsmith
commented
May 8, 2026
|
|
||
| var otherDocs = detail.Document.Where(d => documentIds.Contains(d.CivilDocumentId)); | ||
| // Deduplicate duplicate raw entries coming from file detail payload. | ||
| var otherDocs = detail.Document |
Contributor
Author
There was a problem hiding this comment.
inspired by:
(this is why "duplicate" documents do not display on the frontend, note that the jc-interface will return the same civilDocumentId/imageId in the document array for civil file details, just with different appearance information.
Contributor
There was a problem hiding this comment.
@devinleighsmith it seems like @JTraill did some preliminary work (#1002) regarding the duplicate documents in the Judicial Binder. Based from the PRs' description, we are waiting for the long term decision on how to handle it. I guess, applying the same logic in the backend should work for now.
ronaldo-macapobre
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request for JIRA Ticket: ----jasper-818----
Issue ticket number and link
JASPER-818
Description
Deduplicate documents from jc-interface civil file details request before adding them to judicial binder.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested adding documents to judicial binder that are duplicated in jc-interface.
Checklist: