chore(ci): workflow results jobs (#1833)

Author: DerekRoberts

.github/workflows/.deploy.yml

@@ -59,7 +59,6 @@ on:
 
 env:
   repo_release: ${{ github.event.repository.name }}-${{ inputs.release }}
-  package_tag: ${{ inputs.tag }}
 
 jobs:
   deploys:
@@ -93,12 +92,12 @@ jobs:
           fi
           # Deploy Helm Chart
           helm dependency update
-          helm package --app-version="${{ env.package_tag }}" --version=${{ inputs.tag }} .
+          helm package --app-version="${{ inputs.tag }}" --version=${{ inputs.tag }} .
           
           helm upgrade \
             --set global.autoscaling=${{ inputs.autoscaling }} \
             --set-string global.repository=${{ github.repository }} \
-            --set-string global.tag=${{ env.package_tag }} \
+            --set-string global.tag=${{ inputs.tag }} \
             ${{ inputs.params }} \
             --install --wait --atomic  ${{ env.repo_release }} \
             --timeout ${{ inputs.timeout-minutes }}m \

.github/workflows/analysis.yml

@@ -77,7 +77,6 @@ jobs:
   trivy:
     name: Trivy Security Scan
     if: ${{ ! github.event.pull_request.draft }}
-    needs: [codeql, tests]
     runs-on: ubuntu-22.04
     timeout-minutes: 1
     steps:
@@ -96,3 +95,10 @@ jobs:
         uses: github/codeql-action/upload-sarif@v3
         with:
           sarif_file: "trivy-results.sarif"
+
+  results:
+    name: Analysis Results
+    needs: [tests, codeql, trivy]
+    runs-on: ubuntu-22.04
+    steps:
+      - run: echo "Workflow completed successfully!"

.github/workflows/pr-open.yml

@@ -42,12 +42,9 @@ jobs:
       tag: ${{ github.event.number }}
       release: ${{ github.event.number }}
 
-  validate:
-    name: Validate
+  results:
+    name: PR Results
     needs: [deploys]
-    if: always() && (!cancelled()) && (!failure())
-    uses: bcgov/quickstart-openshift-helpers/.github/workflows/.pr-validate.yml@v0.3.0
-    with:
-      markdown_links: |
-        - [Frontend](https://${{ github.event.repository.name }}-${{ github.event.number }}-frontend.apps.silver.devops.gov.bc.ca)
-        - [Backend](https://${{ github.event.repository.name }}-${{ github.event.number }}-frontend.apps.silver.devops.gov.bc.ca/api)
+    runs-on: ubuntu-22.04
+    steps:
+      - run: echo "Workflow completed successfully!"

.github/workflows/pr-edit.yml .github/workflows/pr-validate.yml.github/workflows/pr-edit.yml renamed to .github/workflows/pr-validate.yml

@@ -1,8 +1,8 @@
-name: PR Edit
+name: PR Validate
 
 on:
   pull_request:
-    types: [edited]
+    types: [edited, opened, synchronize, reopened]
 
 concurrency:
   group: ${{ github.workflow }}-edit-${{ github.event.number }}
@@ -16,3 +16,10 @@ jobs:
       markdown_links: |
         - [Frontend](https://${{ github.event.repository.name }}-${{ github.event.number }}-frontend.apps.silver.devops.gov.bc.ca)
         - [Backend](https://${{ github.event.repository.name }}-${{ github.event.number }}-frontend.apps.silver.devops.gov.bc.ca/api)
+
+  results:
+    name: Validate Results
+    needs: [validate]
+    runs-on: ubuntu-22.04
+    steps:
+      - run: echo "Workflow completed successfully!"