fix(e2e): stabilize playwright chromium tests and prune non-chromium browsers#2764
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the frontend Playwright E2E setup to reduce browser-launch/navigation flakiness in CI by adjusting browser launch flags, TLS handling, and navigation wait conditions.
Changes:
- Configure Playwright to ignore HTTPS certificate errors during tests.
- Add Chromium-based launch arguments (
--no-sandbox,--disable-setuid-sandbox) for Chromium/Chrome/Edge projects. - Update the dashboard page navigation to wait for
domcontentloaded.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
frontend/playwright.config.ts |
Adjusts shared Playwright use options and adds Chromium launch flags to improve CI stability. |
frontend/e2e/pages/dashboard.ts |
Tweaks initial navigation wait condition to reduce load-event-related timeouts/flakes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DerekRoberts
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stabilizes the E2E test runs in CI and cleans up unused browser configurations to optimize pipeline execution.
Changes Included:
--no-sandboxand--disable-setuid-sandboxlaunch arguments for Chromium, gated behindprocess.env.CI === 'true'to bypass unprivileged namespace restrictions in GHA runners (ubuntu-24.04).ignoreHTTPSErrorsunderprocess.env.CI === 'true' || process.env.E2E_IGNORE_HTTPS_ERRORS === 'true'to allow bypassing self-signed cert checks in target test environments without exposing local dev setups.e2e-testsjob in.github/workflows/reusable-tests.ymlto rename the job fromE2E (chromium)to justE2E.Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: